Repository navigation
[FIX] Clear cargo-deny advisories on webpki-roots, rustls-webpki, and tokio - #145
Merged
Merged
Conversation
cargo deny check advisories fails on main for RUSTSEC-2026-0381 (webpki-roots 1.0.7), RUSTSEC-2026-0382 (rustls-webpki 0.103.15), and RUSTSEC-2026-0386 (tokio 1.52.3). Bump those three crates to the patched releases in one commit, because any single bump leaves deny red.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seat: grok-4.7 / xhigh (adversarial review wave 7, 2026-10-25)
Category: [FIX]
Problem / Opportunity:
cargo deny check advisoriesis red on currentmain(1a80d2a). Three advisories from 20–23 October 2026 flagwebpki-roots1.0.7,rustls-webpki0.103.15, andtokio1.52.3. CI runs that check with cargo-deny 0.19.9, somaincannot go green until all three move. Each bump on its own still leaves the other two, so this is one lockfile change.Evidence: Unmodified
mainlock, cargo-deny 0.19.9:Exit 1. The three errors, abbreviated:
Upstream text fetched this session:
>=1.0.10. "Thewebpki-roots0.26.11 compatibility package contains no independent trust store and re-exports the roots from its separately resolved 1.x dependency. That parent dependency must resolve to 1.0.10 or newer.">=0.103.16, <0.104.0-alpha.1OR>=0.104.0-alpha.8.>=1.51.6, <1.52.0OR>=1.53.3. The 1.51 line does not cover the locked 1.52.3, so the smallest patched release on this line is 1.53.3.crates.io version objects fetched this session (checksums match
Cargo.lock):"num":"1.0.11","created_at":"2026-10-23T08:25:08.250247Z","checksum":"f5f280bbb2b287bc8e7de7e3852945a0ff50d1bbcb5ed42b6c7a568c546df171","rust_version":"1.71","yanked":false"num":"0.103.16","created_at":"2026-10-20T08:58:28.008618Z","checksum":"4443b1b6d39d7c663139942cc4558262562d2c84123bb6282ef177009ca8b281","rust_version":"1.71","yanked":false"num":"1.53.3","created_at":"2026-10-13T20:51:46.498182Z","checksum":"ce3335fa71841cda333a58d7615b03901380ecf09d59b3296d21f8bbac0dde4e","rust_version":"1.71","yanked":falserg -n AsyncFdover this worktree returned no matches, so the deprecation ofAsyncFd::new/with_interest/try_new/try_with_interesthas no call site here.Cargo.toml(workspace package and the six internal pins), the seven member stamps inCargo.lock, and the two version lines indocs/gen/pt.1. The historical dashboard note indashboard/README.mdis left as written.Precise updates (cargo 1.98.1):
cargo update -p webpki-roots --precise 1.0.11is ambiguous (webpki-roots@0.26.11andwebpki-roots@1.0.7). The 0.26.11 crate stays. The advisory lists it as unaffected and says it re-exports the 1.x parent; that parent is now 1.0.11.cargo update -p tokio --precise 1.53.3also rewrote Windows-onlywindows-sysedges from 0.61.2 to 0.59.0 or 0.60.2 (anstyle-query, dirs-sys, errno, is-terminal, jiff, nu-ansi-term, rustix, socket2, tempfile, winapi-util). The crates.io index for tokio 1.53.3 still requireswindows-sys ^0.61, the same requirement as 1.52.3, and the other crates' requirements still accept 0.61.2 (anstyle-query>=0.60.2, <0.62;errno/rustix/tempfile>=0.52, <0.62). Those edges are left on 0.61.2. The committed third-party diff is the three version/checksum pairs plus the fourwebpki-roots 1.0.7→1.0.11edges (hyper-rustls, lettre, reqwest, and the 0.26.11 re-export).cargo +1.98.1 metadata --locked --format-version 1 --no-depsexits 0 on that lock and does not rewrite it.PATH=/usr/bin:/bin:$HOME/.cargo/bin,CARGO_HOME=/tmp/ptask-cargo-deny,CARGO_TARGET_DIR=/tmp/ptask-target-deny, toolchain 1.98.1.Dashboard sidecar tests were not run. This diff does not touch
dashboard/. A release--features native-mlbuild was not run; the debug native-ml test and clippy builds were.AsyncFdconstructors deprecated by that release have no call site in this tree, and clippy-D warningsis clean on both feature sets.webpki-roots0.26.11 stays and now re-exports 1.0.11. Revert is a clean single-commit revert of the lockfile and the 3.51.6 stamp.