Skip to content

Revert autonomous credential login - #75

Merged
altaywtf merged 1 commit into
mainfrom
revert/remove-credential-login
Aug 26, 2026
Merged

Revert autonomous credential login#75
altaywtf merged 1 commit into
mainfrom
revert/remove-credential-login

Conversation

@altaywtf

Copy link
Copy Markdown
Member

Summary

The CLI must acquire tokens through its existing browser/device-link flow; it must not accept account credentials or TOTP seeds.

This removes auth login --from-env and its credential/TOTP configuration while retaining the narrowed putio-cli skill trigger.

Verification

  • pnpm exec vp run verify
  • 33 test files and 339 tests passed
  • built auth login help exposes only --open, --output, --profile, and --timeout-seconds

Notes

The encrypted vault credentials remain unchanged for browser automation.

Copilot AI lite review requested due to automatic review settings August 26, 2026 18:40
@altaywtf
altaywtf merged commit ee7c501 into main Aug 26, 2026
7 checks passed
@altaywtf
altaywtf deleted the revert/remove-credential-login branch August 26, 2026 18:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the previously added “autonomous credential login” capability and returns putio auth login to the browser/device-link flow only, removing any support for supplying account credentials or TOTP seeds via config/env.

Changes:

  • Removes auth login --from-env and all supporting credential/TOTP configuration (env vars, config resolver, SDK calls).
  • Deletes the internal TOTP implementation and its tests, and updates command-path mocks/tests accordingly.
  • Updates terminal output/i18n, CLI metadata, and user/skill docs to reflect the narrowed auth flow.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/test-support/command-path-mocks.ts Removes credential/TOTP mocks now that the login path is device-link only.
src/internal/totp.ts Deletes the TOTP implementation.
src/internal/totp.test.ts Removes TOTP vector/validation tests alongside the implementation removal.
src/internal/terminal/auth-terminal.ts Drops “method” output from the login-success terminal rendering.
src/internal/terminal/auth-terminal.test.ts Updates tests to match the simplified terminal output.
src/internal/metadata.ts Removes credential-login environment metadata from the machine-readable describe contract.
src/internal/metadata.test.ts Updates metadata assertions to reflect removed --from-env and env metadata.
src/internal/env.ts Removes PUTIO_CLI_LOGIN_* environment variable constants.
src/internal/config.ts Removes credential-auth config schema/service and its resolver function.
src/internal/config.test.ts Removes tests covering credential-auth config resolution and failure modes.
src/i18n/catalog/en.ts Removes the cli.auth.success.method translation key.
src/commands/auth.ts Removes --from-env flag and credential/TOTP login branch; keeps device-link flow.
src/command-paths.test.ts Removes credential-login command-path coverage and related mocks.
skills/putio-cli/SKILL.md Updates skill guidance to avoid credential login and emphasize profile/device flow.
skills/putio-cli/references/auth.md Removes --from-env guidance from the auth reference doc.
README.md Removes unattended credential-login instructions and references from user docs.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread skills/putio-cli/references/auth.md
putio-releaser Bot added a commit that referenced this pull request Aug 26, 2026
## [1.7.1](v1.7.0...v1.7.1) (2026-08-26)

### Bug Fixes

* publish credential-login removal ([#76](#76)) ([172bdf1](172bdf1))

### Reverts

* remove autonomous credential login ([#75](#75)) ([ee7c501](ee7c501))
@putio-releaser

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants