Revert autonomous credential login - #75
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reverts the previously added “autonomous credential login” capability and returns putio auth login to the browser/device-link flow only, removing any support for supplying account credentials or TOTP seeds via config/env.
Changes:
- Removes
auth login --from-envand all supporting credential/TOTP configuration (env vars, config resolver, SDK calls). - Deletes the internal TOTP implementation and its tests, and updates command-path mocks/tests accordingly.
- Updates terminal output/i18n, CLI metadata, and user/skill docs to reflect the narrowed auth flow.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/test-support/command-path-mocks.ts | Removes credential/TOTP mocks now that the login path is device-link only. |
| src/internal/totp.ts | Deletes the TOTP implementation. |
| src/internal/totp.test.ts | Removes TOTP vector/validation tests alongside the implementation removal. |
| src/internal/terminal/auth-terminal.ts | Drops “method” output from the login-success terminal rendering. |
| src/internal/terminal/auth-terminal.test.ts | Updates tests to match the simplified terminal output. |
| src/internal/metadata.ts | Removes credential-login environment metadata from the machine-readable describe contract. |
| src/internal/metadata.test.ts | Updates metadata assertions to reflect removed --from-env and env metadata. |
| src/internal/env.ts | Removes PUTIO_CLI_LOGIN_* environment variable constants. |
| src/internal/config.ts | Removes credential-auth config schema/service and its resolver function. |
| src/internal/config.test.ts | Removes tests covering credential-auth config resolution and failure modes. |
| src/i18n/catalog/en.ts | Removes the cli.auth.success.method translation key. |
| src/commands/auth.ts | Removes --from-env flag and credential/TOTP login branch; keeps device-link flow. |
| src/command-paths.test.ts | Removes credential-login command-path coverage and related mocks. |
| skills/putio-cli/SKILL.md | Updates skill guidance to avoid credential login and emphasize profile/device flow. |
| skills/putio-cli/references/auth.md | Removes --from-env guidance from the auth reference doc. |
| README.md | Removes unattended credential-login instructions and references from user docs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
🎉 This PR is included in version 1.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CLI must acquire tokens through its existing browser/device-link flow; it must not accept account credentials or TOTP seeds.
This removes auth login --from-env and its credential/TOTP configuration while retaining the narrowed putio-cli skill trigger.
Verification
Notes
The encrypted vault credentials remain unchanged for browser automation.