Repository navigation
Enforce nonzero Schur split factors - #484
Open
leninworld wants to merge 1 commit into
Open
leninworld wants to merge 1 commit into
leninworld wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #426.
Rust’s
ApproxSchurConfig::splitnow usesNonZeroU32, so zero cannot be constructed or deserialized. Python stores the same invariant while keeping its integer API, defaults, read-only getter and existingValueErrormessage. Positive serialized values retain their encoding; existing binary fixtures are unchanged. The Rust field-type change is documented as breaking under Unreleased.Validation:
The Docker runs use native Linux ARM64/Python 3.12. They do not claim the upstream x64/free-threaded, macOS, Windows or complete release-wheel matrix. If #482 lands first, its new
factor_configconversion site will need.get()too.Recorded Docker validation summaries, not fresh terminal captures:
Prepared with AI assistance.
Closes #426.