Repository navigation
Conversation
schroedk
force-pushed
the
feat/365-budget-workspace
branch
from
October 31, 2026 21:21
b564d5f to
e1439e9
Compare
…get and caller scratch (#365) Every apply in schwarz-precond and within takes a thread budget (Par) and caller-owned scratch (MemStack) and cannot fail; Operator, the Schwarz buffer pool and LocalSolveError are gone. LocalSolver declares its scratch per right-hand-side count and budget. Data-parallel kernels fork under the whole budget; independent regions (Schwarz subdomains) divide it through the new par helpers. mlsmr writes into a caller x, starts from an explicit InitialGuess, stops on an optional Staleness rule, and panics on mismatched shapes. within's solve still fans right-hand sides out on the ambient pool and hands each apply Par::rayon(0). Tests build fixtures from faer matrices.
approx-chol splits a block's solve only where it keeps Cᵀ, above 2^17 nonzeros, and splittable_work is then at least 2^18; a subdomain's sum is 0 or past the 200,000 gate, so the gate never changed a decision.
schroedk
force-pushed
the
feat/365-budget-workspace
branch
from
November 1, 2026 14:52
8fe1764 to
a6b01fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #365.
Every operator apply takes a thread budget (
Par) and caller-owned scratch (MemStack) on faer'sLinOp/BiLinOpcontract, and cannot fail.schwarz-precond:Operatorand the Schwarz buffer pool are removed;LocalSolverdeclares scratch per RHS count and budget;mlsmr(op, b, m, x, start, &options, stall, par, scratch)writes intox.within: operators implementLinOp;solvestill fans RHS out on the ambient pool and hands each applyPar::rayon(0);Preconditioner::apply→apply_slices.Stacked on #485. Test fixtures are faer matrices.
thread_countchecks equal bits at 1/2/3/8 threads. Rust 502 passed, pytest 117 passed / 2 skipped.