Repository navigation
Update/add veeru - #957
Update/add veeru#957crhea93 wants to merge 3 commits into
Conversation
✅ Deploy Preview for pyos-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
InessaPawson
left a comment
InessaPawson
left a comment
There was a problem hiding this comment.
@crhea93 Please add Veeru (@dosvk) to https://github.com/orgs/pyOpenSci/teams/editorial-board first.
Since editorial-board.yml is regenerated by update-editorial-board, let’s make sure this entry won't disappear on the next scheduled update. Otherwise, the PR looks good.
|
Ahhh ok is that the correct order of operations for all future ones? |
|
@crhea93 I must admit, I've never onboarded an editor myself. Perusing the onboarding guide, it looks like adding a new editor to the GitHub team should come before submitting a PR to pyopensci.github.io. |
| packages_reviewed: | ||
| location: | ||
| email: | ||
| - name: Veerendra Kumar Sunkavalli |
There was a problem hiding this comment.
@crhea93 before we merge this let's test out my other workflow.
i am not sure what will happen if Verrendra hasn't been added as a contributor yet. but you can use all-contributors to add them as a contributor. also cc'ing @shaunagm on this we will test this workflow out. it might break and that is ok if it breaks we should add this person using the all-contributors bot to the software-submission repository first in our workflow.
There was a problem hiding this comment.
Ok I'm trying the all-contributors first :D
|
ok please see this pr - #960 it turns out that my action didn't have correct permissions and because of that it couldn't add a new contributors but the code was all there ✨ so i had thought about that use case!! i suspect we can close this if 960 looks good and then i will show you all have to manually run this if you need to update people! Finally if this doesn't register on the website that is another issue that we can open and easily fix!! |
|
Ok! And just to be clear, with the new method you put together these PRs will be obsolete? |
YES! if the new workflows look ok to you - and i think they do what you want them to do, instead of submitting pr's you can just trigger the action to run whenever you want and it will also run once a week automagically . we can then close this pr in favor of #960 which is an automated workflow that just had a missing token permission and i just fixed it! |
|
ok so let's close this in favor of #960 |
I added Veeru (dosvk) to both the contributors and editorial_board yml files.