Use f-strings for the remaining log messages#731
Merged
Conversation
Convert the %-style logger calls outside the filesystem modules (which were converted in GH-730) to f-strings, unifying the logging style across the codebase. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The line-based grep missed a multi-line %-style debug call and an info call built from a dynamically appended format string in pandas/result_set.py; convert both to f-strings. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
Converts the remaining %-style logger calls (14 call sites across 7 files: the result-set modules,
pandas/util.py, andspark/common.py) to f-strings. The filesystem modules were already converted in #730, where ruff'sG004(logging-f-string) rule was moved to the ignore list.WHY
Unifies the logging style across the codebase on f-strings, per the maintainer's preference. No behavioral change; the lazy-formatting difference is irrelevant for these exception/info messages.
🤖 Generated with Claude Code