Repository navigation
Normalize Digest authentication parameter names and whitespace - #1305
Open
theamodhshetty wants to merge 1 commit into
Open
theamodhshetty wants to merge 1 commit into
theamodhshetty wants to merge 1 commit into
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DigestAuthrejects valid challenges such asDigest Realm="example", Nonce="abc". Uppercase optional parameter names can also silently dropqop/opaqueor select MD5 instead of the advertised algorithm. Whitespace around=causes the same parsing problem.RFC 9110 §11.2 defines case-insensitive authentication parameter names and permits whitespace around the separator. Normalize names and surrounding whitespace before looking up parameters, preserving case and whitespace inside quoted values.
Extend the existing SHA-256 RFC vector across individual uppercase parameters and space/tab separators, asserting the same digest. Add a regression for preserving quoted whitespace.
Locally on Python 3.15.0:
scripts/coveragepasses at 100% (14,914 statements).scripts/checkpasses: lock consistency, formatting, mypy, Ruff and unasync consistency.Hosted CI now passes on Python 3.11–3.15, including package/docs builds, checks and coverage (Test Suite). Automated reviews report no findings. CodSpeed reports 18 unchanged benchmarks and seven skipped benchmarks using baseline results; this does not establish performance for the skipped cases. Human maintainer review is still pending.
Checklist
AI-assisted investigation, implementation and local validation with Codex.