fix(export): use type names for mutated module EFT export#2778
Open
BHBNSN wants to merge 1 commit into
Open
Conversation
Author
|
The AppVeyor failure appears unrelated to this PR. The Ubuntu AppImage job failed inside appimage-builder while downloading AppRun hooks: urllib.error.URLError: <urlopen error [Errno -3] Temporary failure in name resolution> This PR only changes the mutated module EFT export path from localized |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an EFT export issue when pyfa is running under a non-English locale.
When exporting a fit to clipboard with mutated attributes enabled, the mutation detail block could include a localized module name. Since EFT import expects canonical type names, the exported fit could not be imported again.
This change makes the export path use canonical type names for mutated module entries, regardless of the current UI language.
Problem
Example exported mutation block under a Chinese locale:
The localized module name makes the EFT export invalid for re-import.
Fix
Use the item type name when generating mutated module export text instead of the localized display name.
Expected output:
Testing