Skip to content

fix(export): use type names for mutated module EFT export#2778

Open
BHBNSN wants to merge 1 commit into
pyfa-org:masterfrom
BHBNSN:master
Open

fix(export): use type names for mutated module EFT export#2778
BHBNSN wants to merge 1 commit into
pyfa-org:masterfrom
BHBNSN:master

Conversation

@BHBNSN

@BHBNSN BHBNSN commented Jun 15, 2026

Copy link
Copy Markdown

Summary

This PR fixes an EFT export issue when pyfa is running under a non-English locale.

When exporting a fit to clipboard with mutated attributes enabled, the mutation detail block could include a localized module name. Since EFT import expects canonical type names, the exported fit could not be imported again.

This change makes the export path use canonical type names for mutated module entries, regardless of the current UI language.

Problem

Example exported mutation block under a Chinese locale:

[1] 重型盗墓者紧凑型掠能器
  不稳定的重型掠能器突变质体
  cpu 40.0, maxRange 16000.0, power 1800.0, powerTransferAmount 110.0

The localized module name makes the EFT export invalid for re-import.

Fix

Use the item type name when generating mutated module export text instead of the localized display name.

Expected output:

[1] Heavy Ghoul Compact Energy Nosferatu
  Unstable Heavy Energy Nosferatu Mutaplasmid
  cpu 40.0, maxRange 16000.0, power 1800.0, powerTransferAmount 110.0

Testing

  • Exported a fit containing mutated modules with mutated attributes enabled.
  • Verified that the mutation block uses canonical type names.
  • Verified that the exported EFT can be imported again.

Copilot AI review requested due to automatic review settings June 15, 2026 09:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@BHBNSN

BHBNSN commented Jun 15, 2026

Copy link
Copy Markdown
Author

The AppVeyor failure appears unrelated to this PR.

The Ubuntu AppImage job failed inside appimage-builder while downloading AppRun hooks:

urllib.error.URLError: <urlopen error [Errno -3] Temporary failure in name resolution>

This PR only changes the mutated module EFT export path from localized .name to canonical .typeName, so the failure looks like a transient CI/network issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants