Skip to content

Promote A.4.33 from commented-out to @test_broken #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lodyai wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Promote A.4.33 from commented-out to @test_broken #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,10 +176,11 @@ end
# Summary
#
# - The formulas after XXX are work-in-progress
# - The following formulas are skip for now
# - A.4.27
# - The following formulas are skipped for now
# - A.4.27 (not yet investigated)
# - The following formulas are broken for now
# - A.4.{33, 35}
# - A.4.33 (see issue #14, now @test_broken)
# - A.4.35 (see issue #15)

@test v * v == (v * v).scalar()
@test v * B == v ⋅ B + v ∧ B == v ⨼ B + v ∧ B
Expand Down Expand Up @@ -232,8 +233,8 @@ end
@test A_Bs_Aǂ == A_Bs_Aǂ[s] # A.4.32
end

# TODO this is failing for now
# @test (A₁₋ᵣ * B * (A₁₋ᵣ)ǂ) ∧ (A₁₋ᵣ * C * (A₁₋ᵣ)ǂ) == A₁₋ᵣ.norm()^2 * A₁₋ᵣ * (B ∧ C) * (A₁₋ᵣ)ǂ # A.4.33
# issue #14: norm()^2 involves sqrt; SymPy may not simplify the equality
@test_broken (A₁₋ᵣ * B * (A₁₋ᵣ)ǂ) ∧ (A₁₋ᵣ * C * (A₁₋ᵣ)ǂ) == A₁₋ᵣ.norm()^2 * A₁₋ᵣ * (B ∧ C) * (A₁₋ᵣ)ǂ # A.4.33

if r > 1
function reduce_except(op, arr, j)
Expand Down
Loading