Conversation
bpm_data has shape (n_bpms, n_turns). bpm_data[::-1] reversed the BPM axis (0) and np.maximum.accumulate defaulted to axis 0 too, so the function took a running max across different BPMs instead of building each BPM's decay envelope over turns. This produced a sign-flipped, ~198% wrong damping estimate, corrupting the free-kick phase correction in phase_correction() (runs whenever is_free_kick is set). Fix: reverse and accumulate over the turn axis (axis=1) instead. Includes a regression test with synthetic data at a known ground-truth decay rate, which failed before this fix and passes after it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bpm_data has shape (n_bpms, n_turns). bpm_data[::-1] reversed the BPM axis (0) and np.maximum.accumulate defaulted to axis 0 too, so the function took a running max across different BPMs instead of building each BPM's decay envelope over turns. This produced a sign-flipped, ~198% wrong damping estimate, corrupting the free-kick phase correction in phase_correction() (runs whenever is_free_kick is set).
Fix: reverse and accumulate over the turn axis (axis=1) instead.
Includes a regression test with synthetic data at a known ground-truth decay rate, which failed before this fix and passes after it.
Fixes #590