Skip to content

Add a saved document library and in-app PDF reader - #255

Closed
fidanci wants to merge 11 commits into
pynicolas:mainfrom
fidanci:personal/customizations
Closed

fidanci wants to merge 11 commits into
pynicolas:mainfrom
fidanci:personal/customizations

Conversation

@fidanci

@fidanci fidanci commented Oct 11, 2026

Copy link
Copy Markdown

Hi Nicolas,

Thank you for building FairScan and keeping it open source. I started this as a personal customization because I wanted to revisit scans after exporting them. This PR adds a saved-documents screen with import, share, rename, and delete actions, plus an in-app PDF reader with page navigation, fit-to-page, pinch zoom, and free panning.

I understand FairScan intentionally keeps its scanning workflow simple, so this may be broader than the project’s intended scope. I tested the flow on my Android phone; the build, 105 unit tests, and lint checks pass. I’m sharing it as an optional contribution for your review. Please feel free to suggest a smaller scope or close the PR if it does not fit the project.

Thanks for your time!

@pynicolas

Copy link
Copy Markdown
Owner

Hi @fidanci,

Thanks a lot for this PR, and for the care you put into it (tests and lint included). I tried it and it works well: nice job!

As you anticipated though, it's outside the scope I want for FairScan. I'm deliberately keeping the app focused on scanning, and leaving storage and PDF viewing to other apps that do them well. I mentioned that in blog posts such as https://fairscan.org/blog/keeping-fairscan-simple/

In fact, FairScan used to have a list of recently saved documents on its home screen. I removed it, partly because of privacy questions it raised and partly to make the app simpler. A saved-documents library would bring that back, in a bigger form.

If something is still missing for you, I'd be happy to hear about the problem you're trying to solve in an issue (rather than a solution).

For now I'm closing this PR. Thanks again!

@pynicolas pynicolas closed this Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants