PYR1-1686 Publish GeoPackage layers under the path-joined store name - #100
Merged
Merged
Conversation
The :geopackage branch aliased the feature type to the bare filename while :shapefile used store-name, so nested files lost their directory prefix: elmfire/landfire/fire-area_TS.gpkg published as fire-area_TS rather than elmfire_landfire_fire-area_TS. Pyregence parses the model and fuel back out of that name, so Risk with Ignition Pattern "Transmission lines" matched no layers for impacted structures, fire area and fire volume.
lambdatronic
previously requested changes
Sep 10, 2026
lambdatronic
left a comment
lambdatronic
left a comment
Contributor
There was a problem hiding this comment.
Can you remove the comments on lines 250-252 in core.clj? Otherwise, this looks fine to me.
Are we sure this isn't going to cause any trouble for the other GeoPackage layers that aren't in the risk tab, such as the various optional (checkbox) layers?
Collaborator
Author
I'll take this to dev and test it there today to confirm it all |
Collaborator
Author
|
testing... 
I've de-then-reregister both tlines and us-transmission-lines. |
kbeehler-sig
approved these changes
Sep 10, 2026
danielhvs
dismissed
lambdatronic’s stale review
September 10, 2026 19:21
Katy also tested and reported OK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Risk -> Ignition Pattern "Transmission lines" showing no data for
impacted structures, fire area and fire volume on development and staging.
The bug
file-spec->layer-specsnamed the published feature type differently per storetype.
:shapefilealiased tostore-name, the relative path joined withunderscores.
:geopackagealiased tolayer-name, the bare basename. NestedGeoPackages therefore lost their directory prefix:
Pyregence parses the model and fuel back out of that layer name, then requires
its request filter set to be a subset of the layer's. The shortened name never
yields
elmfireorlandfire, so the lookup returned zero layers.Relative burn probability was unaffected because it ships as GeoTIFFs through
the ImageMosaic path, which already used
store-name.The change
:geopackagebranch aliasesnative-nametostore-name, guards on(not= native-name store-name), and points the style atstore-name.file-spec->layer-specs. One asserts the nested casepublishes the path-joined name; two pin the flat cases so the existing
fire-detections layers keep the names they have.
Side effect worth noting
The validation and spatial-index paths in
core.cljalready addressed layers asworkspace:store-name. For nested GeoPackages that name did not exist, so thosechecks were querying a layer that was never published. They line up now.