PYR1-1799 Omit empty GWC extents from tile-layer PUTs - #103
Merged
Merged
Conversation
GeoServer-created tile layers carry grid subsets with only a gridSetName. update-cached-layer and update-cached-layer-metatiling copied them back as <extent><coords></coords></extent>, and GWC threw ArrayIndexOutOfBoundsException in BoundingBox.hashCode, failing the PUT with a 500. Write the extent only when the subset has coords.
danielhvs
marked this pull request as ready for review
September 24, 2026 14:53
lambdatronic
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Stop GeoSync from sending an empty
<extent>in GWC tile-layer PUTs. On dev,fire-detections_active-firesandfire-detections_firis-perimetersfailed registration on every run with a GWC 500, so the 1x1 metatile from #102 never landed and those layers stayed atmetaWidthHeight [4, 4].Cause
A tile layer that GeoServer creates itself has grid subsets with only a
gridSetName, which means full gridset coverage. Live on geoserver-dev:Both PUT builders copied those subsets back and always wrote
<extent><coords></coords></extent>. GWC then fails to hash the empty bounding box:Changes
update-cached-layerandupdate-cached-layer-metatilingwrite<extent>only when the subset has coordsupdate-cached-layeris the raster TIME-filter path, and it had this bug before #102. It is behind the utilityfire-weather-forecast_ecmwf_*registration failures on dev, which also appear before #102 was deployed.Verified on dev
Both dev GeoSync UberJARs were built from
0a6bdc2, and I ran the syncs by hand:sync-fire-detectionson geoserver-dev: 0 registration failures, down from 2 on3af114a(active-fires,firis-perimeters)fire-detections_{active-fires,firis-perimeters,fire-history}tile layers now reportmetaWidthHeight [1, 1]and keep both grid subsetsArrayIndexOutOfBoundsExceptionsince the jar swapsync-fire-weather-forecaston geoserver-utility-dev:fire-weather-forecast_ecmwf_20260924_00returnsstatus 0, Workspace updated. It failed 4 times earlier todayRelated Issues
Closes PYR1-1799
Relates to PYR1-1786