PYR1-938: register weather and risk time series as ImageMosaics - #98
Merged
Merged
Conversation
5 tasks
danielhvs
force-pushed
the
PYR1-938-weather-risk-image-mosaics
branch
5 times, most recently
from
September 1, 2026 16:00
3f5ee60 to
8c4cc87
Compare
geosync creates mosaic coverages with no band metadata, so ncWMS GetTimeSeries failed with an empty property list. Measured on geoserver-dev against hrrr ws, 49 timesteps: GetTimeSeries 1 request 153 ms 1534 bytes GetFeatureInfo x49 49 requests 675 ms Values agree at every timestep. Without a declared band, omitting PROPERTYNAME threw IndexOutOfBoundsException on coverage.getDimensions().get(0): https://github.com/geoserver/geoserver/blob/f8e492cd0fe21c54df4840ea1241f633a440fdd9/src/community/ncwms/src/main/java/org/geoserver/wms/ncwms/NcWmsService.java#L179-L182 Callers passed PROPERTYNAME=GRAY_INDEX to sidestep that. With the band declared the same block resolves the first band on its own: dropping the parameter returns byte-identical CSV, measured over 209 timesteps of gfs0p25 tmpf.
danielhvs
force-pushed
the
PYR1-938-weather-risk-image-mosaics
branch
from
September 1, 2026 16:09
8c4cc87 to
6a7b4e3
Compare
danielhvs
marked this pull request as ready for review
September 1, 2026 16:15
noelrivasc
approved these changes
Sep 9, 2026
noelrivasc
left a comment
noelrivasc
left a comment
Collaborator
There was a problem hiding this comment.
LGTM and it's working properly on dev and stg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register weather and risk time series as ImageMosaics instead of one layer per
timestep, so a single layer carries the whole time dimension.
GRAY_INDEXband on mosaic coverages. Without band metadata thencWMS
GetTimeSeriesrequest fails, which is the request that returns thewhole series at a point in one call.
Frontend side: PYR1-938: register weather and risk time series as ImageMosaics. Both have to
ship together - the frontend reads the series from the mosaics this PR creates.