No Jira Issue: keep dots in workspace names out of REST path extension parsing - #99
Merged
Merged
Conversation
GeoServer and GWC strip everything after the last "." of the final path segment as a format extension, so removing fuels-and-topography_landfire-2.5.0 resolved to ...landfire-2.5 and 404'd on all six cached layers and on the workspace itself. 1. delete-workspace terminates the name with "/", as get-workspace and update-workspace already do. 2. delete-cached-layer appends ".xml", as update-cached-layer already does. 3. get-cached-layer appends ".json" rather than ".xml" because get-existing-gwc-layer reads that body with json/read-str.
aliceliquori
approved these changes
Aug 28, 2026
aliceliquori
left a comment
aliceliquori
left a comment
There was a problem hiding this comment.
Paths like this are always so sneaky. Good work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing a workspace whose name contains a dot failed. GeoServer and GWC strip everything after the last
.of the final path segment as a format extension, sofuels-and-topography_landfire-2.5.0resolved tofuels-and-topography_landfire-2.5and returned 404 for all six cached layers and for the workspace itself, ending inGeoSync: Errors encountered during workspace removal.delete-workspaceterminates the name with/, asget-workspaceandupdate-workspacealready do.delete-cached-layerappends.xml, asupdate-cached-layeralready does.get-cached-layerappends.jsonrather than.xml, becauseget-existing-gwc-layerreads that body withjson/read-str.Resulting paths for a dotted workspace:
Verified against a live GeoServer in development. Eleven
fuels-and-topography_landfire-*workspaces carry dots and were all affected.Not covered: roughly 25 other paths in
rest_api.cljend in a user-controlled name (datastores/<store>,layers/<layer>,coverages/<coverage>,layergroups/<group>,namespaces/<ws>) and have the same weakness. No current layer name contains a dot, so they are left alone here.