Allow usage of zero-length element - #435
gubaidulinvadim wants to merge 3 commits into
Conversation
|
I am not sure. For which reasons we should throw an error instead of making it work with the integrated strength? |
|
It is so that it does not fail silently and will not confuse the user. I'd imagine you would also need the length to do the actual conversion to current. There are no thin elements in the control system. |
I think I disagree, in SOLEIL MML lattice all the corrector (skew, H/V) and even part of the sextupoles are thin magnets. I don't like it but there is no problem for unit conversion. I think we should still allow for thin magnets to be controlled to be compatible with AT lattice which uses it. @simoneliuzzo @TeresiaOlsson What do you think? |
|
I think so too. We also had thin correctors in MML before I made them thick so could be that many labs have that and transitioning between MML and pyAML will be less easy if we don't allow it. |
…ength is given. Issues a warning.
|
As you wish |
|
I proposed a solution in #360 |
Closes #360 by introducing a pyAMLException when the user tries to set a zero-length element.
@GamelinAl does this answer your issue?