Fix issue with apparent codeblock within other codeblock#3527
Open
brass75 wants to merge 6 commits into
Open
Conversation
If there is a triple quoted string inside a codeblock that that appears invalid the current implementation will trigger the the "Bat ticks message". This is confusing to the user and generally wrong because that happens to be correct. What needs to happen is that the we should isolate the codeblocks and make sure that the violating codeblock is not contained within a codeblock. This change handles that scenario by checking all of the invalid codeblocks to generate the correct message based on the invalid codeblock. If a message contains multiple invalid codeblocks and there is at least one that is using invalid ticks the invalid ticks message will be shown. If there is no codeblock with invalid ticks the missing language and no language logic will be followed without change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is a triple quoted string inside a
codeblockthat appears invalid the current implementation will trigger the the "Bat ticks message". This is confusing to the user and generally wrong because that happens to be correct. What needs to happen is that the we should isolate thecodeblocks and make sure that the violatingcodeblockis notcontained within acodeblock.This change handles that scenario by checking all of the invalid
codeblocks to generate the correct message based on the invalidcodeblock. If a message contains multiple invalidcodeblocks and there is at least one that is using invalid ticks the invalid ticks message will be shown. If there is nocodeblockwith invalid ticks the missing language and no language logic will be followed without change.Fixes #3522