Add arm64 support to CI Docker builds#2
Open
ChrisLovering wants to merge 6 commits into
Open
Conversation
ChrisLovering
force-pushed
the
ci/arm64-builds
branch
from
4182cca to
253cc7e
Compare
MarkKoz
suggested changes
Jun 24, 2026
|
|
||
| [config] | ||
| versions = [ | ||
| "3.14", |
Comment on lines
+54
to
+55
| - name: Set up QEMU | ||
| uses: docker/setup-qemu-action@v4 |
| ghcr.io/python-discord/python-builds:builder-base | ||
| ghcr.io/python-discord/python-builds:builder-base-${{ needs.pyenv-version.outputs.pyenv_version }} | ||
|
|
||
| - name: Run Docker container to resolve versions |
There was a problem hiding this comment.
Was there no reason to run this script inside Docker in the first place?
Comment on lines
+100
to
+101
| ghcr.io/python-discord/python-builds:${{ inputs.tag }}-linux-amd64 \ | ||
| ghcr.io/python-discord/python-builds:${{ inputs.tag }}-linux-arm64 |
There was a problem hiding this comment.
Is there a way to avoid hard-coding the platforms here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds and pushes multi-platform Docker images for both amd64 and arm64.