Apply restrict optimizations to ImagingQuantize's output loop - #10006
Merged
Merged
Conversation
radarhere
reviewed
Sep 16, 2026
akx
marked this pull request as ready for review
September 16, 2026 08:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up on #9752 (comment) and #9740.
None of the other loops in the quantization "frontend" were eligible for
restrict, but this does speed up quantization a little bit, more so when the quantization method itself is fast (such as FastOctree).Note the below local benchmark is with larger images than the default. CodSpeed probably won't show comparisons here since the test IDs change.
I also noticed
MAXCOVERAGEis painfully slow with images with a large number of distinct colors, but I think that would require a more thorough rework. By and large, the quantization code (and its hash table code) is from 1998 or so, written with machines from that era in mind.