Enable Mypy strict mode - #9803
Conversation
|
Given that this is considerably smaller than #9410, I suspect you're only fixing the strict mode problems that arose testing against Python 3.11. #9410 had its sights set a bit higher - it actually wanted to correct strict mode problems for newer versions of Python as well, which fell into an unresolved debate about whether to test against those versions or not. But that isn't necessarily something to stop this PR from being merged. I just suspect it doesn't exactly replace #9410. |
|
Same result on all supported Pythons. $ for py in 3.11 3.12 3.13 3.14; uvx -q --python=$py --with-requirements=.ci/requirements-mypy.txt mypy conftest.py selftest.py setup.py checks docs src winbuild Tests; end
Success: no issues found in 303 source files
Success: no issues found in 303 source files
Success: no issues found in 303 source files
Success: no issues found in 303 source files
$ |
|
radarhere@cfb3ab8 added to these changes gives failures on 3.12 - 3.14. |
9d6a2b9 to
4ce1298
Compare
| fail-fast: false | ||
| matrix: | ||
| python-version: [ | ||
| "3.14", |
There was a problem hiding this comment.
Note to self - it appears apache/arrow#48172 is blocking 3.15 support
|
A review was requested, so I'll restate - the fundamental issue here isn't any implementation detail, it's the question of whether we should do this - #9414 (comment)
python/mypy#12286 is an issue requesting the ability to check multiple versions at once. From the fact that it is still open, you might infer that this isn't an official priority.
|
|
I'm also not sure if we need to enable strict mode, some of our annotations are pretty complex already and I don't think the The |
ce41f6f to
0e62d45
Compare
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com> Co-authored-by: Aarni Koskela <akx@iki.fi>
…sions Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
32e44fd to
d11ad9b
Compare
Rebase of #9410, with the type fixes reduced to the minimum required to make
uvx --python=3.11 --with-requirements=.ci/requirements-mypy.txt mypy conftest.py selftest.py setup.py checks docs src winbuild Testspass. Most of the conflicts there were post f80b914 merge.Closes #9410.