Move kernel size check into getlist() - #9987
Open
radarhere wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Within
_prepare_lut_table(),_point()and_transform(), a size is passed togetlist()Pillow/src/_imaging.c
Line 878 in 0253ef0
which then checks it and raises a ValueError if it is incorrect.
Pillow/src/_imaging.c
Lines 447 to 450 in 0253ef0
However,
_filter()asksgetlist()for the length and then checks it afterwards.Pillow/src/_imaging.c
Line 1170 in 0253ef0
Pillow/src/_imaging.c
Lines 496 to 498 in 0253ef0
Pillow/src/_imaging.c
Lines 1174 to 1177 in 0253ef0
It would be simpler to use the same strategy for all scenarios.