Correct ImageOps.crop border type hint - #9989
Open
lllleolin-max wants to merge 4 commits into
Open
Conversation
Document supported border tuple ordering and cover all border forms. Assisted-by: OpenAI GPT-6 <noreply@openai.com>
Member
|
I've created lllleolin-max#1 with suggestions. |
Update docstring
radarhere
approved these changes
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ImageOps.crop(im, (1, 2))andImageOps.crop(im, (1, 2, 3, 4))already work through_border(), but type checkers reject them becausecrop()only annotatesborderasint.Changes proposed in this pull request:
crop()annotation, consistent withexpand().crop()always removes the same border on every side.Validation:
MYPYPATH=src,python3 -m mypy --follow-imports=silent --ignore-missing-imports Tests/test_imageops.py: the new test produces onearg-typeerror with the old annotation, and passes with the updated annotation.Tests/test_imageops.pypass with the checkout'sImageOpsmodule and Pillow 12.3.0's prebuilt native extensions on Windows/Python 3.12. The native extensions were not rebuilt.git diff --checkpass for the changed files.ImageOpsmodule and Pillow 12.3.0 for the other modules.Prepared with AI assistance.