Skip to content

docs: clarify external partial resume confirmation#450

Merged
nijel merged 1 commit into
python-social-auth:masterfrom
nijel:partial-resume
Jun 23, 2026
Merged

docs: clarify external partial resume confirmation#450
nijel merged 1 commit into
python-social-auth:masterfrom
nijel:partial-resume

Conversation

@nijel

@nijel nijel commented Jun 23, 2026

Copy link
Copy Markdown
Member

No description provided.

@nijel nijel self-assigned this Jun 23, 2026
@nijel nijel enabled auto-merge (rebase) June 23, 2026 17:48
@nijel nijel merged commit b98b047 into python-social-auth:master Jun 23, 2026
3 checks passed
@nijel nijel deleted the partial-resume branch June 23, 2026 17:49

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a64d075618

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/pipeline.rst
Comment on lines +351 to +352
Externally resumed partials do not resume immediately when a request supplies
the partial token, even in the browser session that created the partial. The

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the same-session resume qualifier

This overstates the current behavior for allow_external_resume partials: social_core.utils._select_partial_pipeline_token() still treats request_token == session_token as an owned token before considering the external confirmation path, so a link opened in the browser session that created the partial resumes immediately and never renders the confirmation page. Users following this text will expect a confirmation step in same-session email/self-click flows that the library does not provide; keep the “different browser session” qualifier here and in the email-validation paragraph.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant