Skip to content

fix(cron): accept day-of-week 7 as a valid Sunday alias #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gaoflow wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −1
Open

fix(cron): accept day-of-week 7 as a valid Sunday alias #470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/validators/cron.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ def cron(value: str, /):
return False
if not _validate_cron_component(months, 1, 12):
return False
if not _validate_cron_component(weekdays, 0, 6):
if not _validate_cron_component(weekdays, 0, 7):
return False

return True
3 changes: 3 additions & 0 deletions tests/test_cron.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@
"0 3-6 * * *",
"*/15 0,6,12,18 * * *",
"0 12 * * 0",
"0 12 * * 7",
"0 0 * * 0-7",
"0 0 * * 0,7",
"*/61 * * * *",
# "5-10/2 * * * *", # this is valid, but not supported yet
],
Expand Down