[Parser] Clean up unused variables and emitted semicolons in asdl_c.py#151455
Closed
CoderSilicon wants to merge 4 commits into
Closed
[Parser] Clean up unused variables and emitted semicolons in asdl_c.py#151455CoderSilicon wants to merge 4 commits into
CoderSilicon wants to merge 4 commits into
Conversation
Updated formatting and added emphasis to copyright and license information. Improved clarity in several sections.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Member
|
Hello, as noted in the devguide, we do not accept PRs proposing solely cosmetic changes, this includes running a linter. Sorry, but I'm closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR cleans up the code inside
Parser/asdl_c.pyby removing unused variable assignments that were cluttering the function scopes, and refactors trailing string-literal formatting to eliminate unneeded emitted semicolons in the generated AST output definitions.Details