[peewee] add typed fields, queries, and update to some of the new APIs#15911
Open
coleifer wants to merge 8 commits into
Open
[peewee] add typed fields, queries, and update to some of the new APIs#15911coleifer wants to merge 8 commits into
coleifer wants to merge 8 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Author
|
Alrighty, I think this one's ready for review any time. Let me know if you have any q's or feedback - I think these changes will massively improve ergonomics for peewee users (all 3 of us lol). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to get Peewee's typing a little bit nicer and bring in some of the additions since 4.0.5.
Added:
For field access - peewee uses metaclass magic along with descriptors, kinda like Django. Fields are now generic over their Python value, so
Model.fieldis the field instance for building queries, andinstance.fieldis the value (e.g. str for CharField, related model for a ForeignKeyField, etc). Also specifyingnull=Truemakes the instance value optional, which is nice.