Repository navigation
Bump GitHub Actions off the deprecated Node 20 runtime - #253
Merged
Merged
Conversation
GitHub now warns on every run of this workflow:
Node.js 20 is deprecated. The following actions target Node.js 20 but
are being forced to run on Node.js 24: actions/download-artifact@v4,
seemethere/upload-artifact-s3@v5
Bumps the five first-party actions to their current majors. astral-sh/setup-uv
is already current and is left alone.
seemethere/upload-artifact-s3 is deliberately not touched here. v5 is its
latest release, so it cannot be fixed by a version bump -- it needs replacing
with pytorch/test-infra/.github/actions/upload-artifact-s3, which expects
`permissions: id-token: write` for OIDC. This workflow sets no permissions
block today and the upload currently succeeds off the self-hosted runner's
instance profile, so that swap risks breaking doc previews and cannot be
validated before it lands. Left as a follow-up.
Test Plan:
CI on this PR exercises the whole workflow: build-docs runs checkout,
setup-python, setup-node and upload-artifact, and doc-preview runs
download-artifact. A green run plus a doc preview that still publishes
covers every bumped action.
Authored with the assistance of an AI coding agent.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
✅ Deploy Preview for pytorchsphinxtheme ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
malfet
marked this pull request as ready for review
August 25, 2026 16:20
Merged
malfet
added a commit
that referenced
this pull request
Aug 27, 2026
* Bump theme to 0.4.12 Picks up the search relevance fix (#252) and the GitHub Actions Node 20 bumps (#253). Goes straight from 0.4.10 to 0.4.12. 0.4.11 was published to PyPI on 2026-05-19 from the `bump-theme-0.4.11` branch, which was never merged, so the branch still read 0.4.10 and there is no 0.4.11 changelog entry. This bump lands on the branch so the next release does not inherit the same gap. Test Plan: ``` python3 -c "import pytorch_sphinx_theme2 as t; print(t.__version__)" grep -rn '0\.4\.12' setup.py pytorch_sphinx_theme2/__init__.py ``` All three version strings (setup.py, __version__, and the dict returned by setup()) report 0.4.12. Authored with the assistance of an AI coding agent. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * Backfill v0.4.11 changelog entry 0.4.11 shipped to PyPI on 2026-05-19 but its bump branch was never merged, so the changelog jumped 0.4.10 to 0.4.12 while the code it contained (#251) is on the branch and reaches anyone upgrading from 0.4.10. Recording it as its own section keeps that accurate for both sets of users, rather than folding it into v0.4.12 and telling existing 0.4.11 users about changes they already have. Authored with the assistance of an AI coding agent. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every run of
build-theme.ymlcurrently ends with:Bumps the five first-party actions to their current majors:
actions/checkoutactions/setup-pythonactions/setup-nodeactions/upload-artifactactions/download-artifactastral-sh/setup-uv@v5is already current and is left alone.Not included
seemethere/upload-artifact-s3@v5is the other action named in the warning, but v5 is its latest release — it can't be fixed by a bump. It needs replacing withpytorch/test-infra/.github/actions/upload-artifact-s3, which expectspermissions: id-token: writefor OIDC. This workflow sets nopermissions:block today and the upload currently succeeds off the self-hosted runner's instance profile, so that swap risks breaking doc previews and can't be validated before landing. Left as a follow-up.Runner labels were checked and are fine:
linux.2xlargeis a current entry in test-infra'sscale-config.ymland thedoc-previewjob completes on it in about a minute.Test plan
CI on this PR exercises the whole workflow —
build-docsruns checkout, setup-python, setup-node and upload-artifact;doc-previewruns download-artifact. A green run plus a doc preview that still publishes covers every bumped action.Authored with the assistance of an AI coding agent.