Repository navigation
Remove auto-approve workflow - #742
Open
tkoyama010 wants to merge 1 commit into
Open
tkoyama010 wants to merge 1 commit into
tkoyama010 wants to merge 1 commit into
Conversation
The autoapprove job can never run via workflow_dispatch because its 'if' condition depends on issue_comment event context (github.event.comment, github.event.issue.number), which does not exist for workflow_dispatch. With the issue_comment trigger removed, the workflow is dead code, so delete it outright. This also resolves the zizmor dangerous-triggers finding raised by the zizmor 1.31.1 update in pre-commit.ci's autoupdate PR.
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove
.github/workflows/auto-approve.yml.The
autoapprovejob depends entirely on theissue_commenttrigger: itsifcondition checksgithub.event.comment.bodyfor@pyvista-bot LGTMfrom a specific list of usernames, and the approve step usesgithub.event.issue.number. These fields do not exist forworkflow_dispatchruns, so the job can never run withoutissue_comment. The workflow is therefore dead code without that trigger.Removing the workflow also resolves the
dangerous-triggers(high severity) finding that zizmor v1.31.1 raises for theissue_commenttrigger — the failure currently blocking the pre-commit.ci autoupdate PR (#741).Notes for reviewers
@pyvista-bot LGTMcomment flow can approve PRs directly (or withgh pr approve <number>); the bot path is no longer available after this change.# zizmor: ignore[dangerous-triggers]suppression.