You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
C2v symmetry operations has the mirror plane around the wrong axis #562
I need a sanity check on this please. Looking at ITOC and "Structure of Materials" (DeGraef 2012), I believe the symmetry group C2v in orix is incorrect:
@maclariz or @hakonanes any chance you can comment on this? @argerlt have you checked the other symmetries as well? Is this something that we could hardcode a sanity check using ITOC?
Yes, I did go though and check all the point groups, line by line, with a physical copy of ITOC volA next to me. C2v is the only PG I found whose elements didn't match up with ITOC.
As a final exhaustive check, as part of #563, I wrote code to proceedurally generate all 32 stereographic plots, and they do, in fact, match ITOC, which seems about as close to verification as we can get.
Is this something that we could hardcode a sanity check using ITOC?
The only additional check I can think of would be to check that the highest order inversion/rotoinversion is always around z. Other than that, we do have hard-coded checks, it's just this one in particular was check with a flipped axes assumption.
changed the title [-]`orix.quaternion.symmetry.C2v` has the mirror plane around the wrong axis[/-][+]C2v symmetry operations has the mirror plane around the wrong axis[/+]on Jul 3, 2025
How the symmetry operations of a point group rotate a vector with unique components (x, y, z) is actually a good test. We should consider add some of these.
Activity
CSSFrancis commentedon Jul 2, 2025
@maclariz or @hakonanes any chance you can comment on this? @argerlt have you checked the other symmetries as well? Is this something that we could hardcode a sanity check using ITOC?
argerlt commentedon Jul 2, 2025
Yes, I did go though and check all the point groups, line by line, with a physical copy of ITOC volA next to me.
C2vis the only PG I found whose elements didn't match up with ITOC.As a final exhaustive check, as part of #563, I wrote code to proceedurally generate all 32 stereographic plots, and they do, in fact, match ITOC, which seems about as close to verification as we can get.
The only additional check I can think of would be to check that the highest order inversion/rotoinversion is always around z. Other than that, we do have hard-coded checks, it's just this one in particular was check with a flipped axes assumption.
CSSFrancis commentedon Jul 2, 2025
@argerlt That seems good enough for me :) Thanks for doing that! It's tedious work, I think I owe you a beer after that :)
[-]`orix.quaternion.symmetry.C2v` has the mirror plane around the wrong axis[/-][+]C2v symmetry operations has the mirror plane around the wrong axis[/+]hakonanes commentedon Jul 3, 2025
Good catch, @argerlt.
The vector (1, 2, 3) rotated with the four symmetry operations correspond to 2mm, so 211, i.e. a two-fold rotation around x, as you say:
(x, y, -z)
(x, -y, z)
(x, -y, -z)
(x, y, z)
hakonanes commentedon Jul 13, 2025
How the symmetry operations of a point group rotate a vector with unique components (x, y, z) is actually a good test. We should consider add some of these.
hakonanes commentedon Nov 4, 2025
This should be fixed in #601.