Repository navigation
Vector tensor product - #681
Merged
Merged
Conversation
Closed
… available functionality Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Member
|
Going over this now. Seems like a great addition to vector arithmetics! @argerlt, is it OK if I add an example with vector arithmetics to the gallery, including a section on vector tensor products? This requires a new vector examples section, with vector arithmetics as the first example (and, for now, only). |
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Member
|
I got the go-ahead off GitHub, so I've added the example. I've also touched up the docstrings and fixed the return type hint. Just have to go over the tests, then we can merge. |
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
hakonanes
approved these changes
Oct 14, 2026
Member
|
@argerlt, feel free to merge this! I may do so within a couple days if you don't. |
Collaborator
Author
|
I like these additions, and I also really like the new example. Merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Vector3d.tensorandVector3d.tensor_outerNOTE: this looks like a large update, but 300+ lines are just reformatting existing tests.
I would like to add this to the 0.16 release if possible.
Progress of the PR
Minimal example of the bug fix or new feature
For reviewers
__init__.py.section in
CHANGELOG.rst.__credits__inorix/__init__.pyand in.zenodo.json.