WORKAROUND: tty: serial: qcom_geni: Skip pm_runtime for qcom,geni-uart-hs#1410
Open
q-AnupKulkarni wants to merge 1 commit into
Open
WORKAROUND: tty: serial: qcom_geni: Skip pm_runtime for qcom,geni-uart-hs#1410q-AnupKulkarni wants to merge 1 commit into
q-AnupKulkarni wants to merge 1 commit into
Conversation
…t-hs The qcom,geni-uart-hs compatible does not rely on the pm_runtime framework for power management. Calling pm_runtime_enable()/disable() in probe/remove is therefore unnecessary and may lead to incorrect or redundant power management handling. Skip pm_runtime usage for this compatible and instead invoke geni_serial_resources_on/off() directly from the .pm callbacks. Signed-off-by: Sai Srinivas <saisrini@qti.qualcomm.com> Signed-off-by: Anup Kulkarni <anup.kulkarni@oss.qualcomm.com>
qcomlnxci
requested review from
a team,
jseerapu,
mukesh-savaliya and
vdadhani
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The qcom,geni-uart-hs compatible does not rely on the pm_runtime framework for power management.
Calling pm_runtime_enable()/disable() in probe/remove is therefore unnecessary and may lead to incorrect or redundant power management handling.
Skip pm_runtime usage for this compatible and instead invoke geni_serial_resources_on/off() directly from the .pm callbacks.