test change

[roopak-houji]

Inserted string in the usb device register

Upstream-Status: Pending

Signed-off-by: Roopak Houji rhouji@qti.qualcomm.com

[qswat-orbit-external]

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

[qlijarvis]

PR #1413 — validate-patch

PR: #1413

Verdict	Issues	Detailed Report
❌	5	Full report

Final Summary

1. Lore link present: No — Patch 1 has no upstream claim; Patch 2 claims FROMLIST but provides no Link: tag
2. Lore link matches PR commits: N/A — No lore links to compare against
3. Upstream patch status: Not upstream — These are test commits that would be rejected immediately if posted
4. PR present in qcom-next: Not checked — These commits should not exist in any branch

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1413 (test change + FROMLIST: arm64: driver:qcom: kaanapali: add dummy debug prints)
Upstream commit: N/A
Verdict: ❌ FAIL

---

Patch 1/2: "test change"

Commit Message

Check	Status	Note
Subject matches upstream	❌	No upstream reference; subject is non-descriptive ("test change")
Body preserves rationale	❌	Minimal body; no proper justification for the change
Fixes tag present/correct	N/A	Not a fix commit
Authorship preserved	⚠️	Malformed Signed-off-by (missing < > around email)
Backport note (if applicable)	N/A	Not a backport

Diff

File	Status	Notes
drivers/usb/core/driver.c	❌	Adds debug string ", test_change" to pr_info with no justification

Issues

• Commit subject: "test change" is not acceptable for kernel commits; must describe what and why
• Commit body: "Inserted string in the usb device register" is vague and grammatically incorrect
• Signed-off-by: Malformed - Signed-off-by: Roopak Houji rhouji@qti.qualcomm.com missing angle brackets
• Code change: Adding ", test_change" to a pr_info message serves no functional purpose and pollutes kernel logs
• Upstream-Status: "Pending" tag suggests this is intended for upstream, but the change is not upstreamable

Verdict

Reject — This appears to be a test/debug commit that should never be merged. Non-descriptive subject, malformed tags, and adds meaningless debug text to kernel logs.

---

Patch 2/2: "FROMLIST: arm64: driver:qcom: kaanapali: add dummy debug prints for kernel build verification"

Commit Message

Check	Status	Note
Subject matches upstream	❌	FROMLIST prefix present but no lore link provided
Body preserves rationale	❌	Admits to adding "dummy debug prints" for build verification only
Fixes tag present/correct	N/A	Not a fix commit
Authorship preserved	⚠️	Email mismatch: From: rhouji@qti.qualcomm.com, Signed-off-by: rhoujik@qti.qualcomm.com
Backport note (if applicable)	N/A	Claims FROMLIST but no Link tag present

Diff

File	Status	Notes
drivers/usb/core/driver.c	❌	Adds printk debug statement with no functional value

Issues

• FROMLIST prefix: Claims patch is from a mailing list but provides no Link: tag to lore.kernel.org
• Subject mismatch: Subject says "arm64: driver:qcom: kaanapali" but modifies drivers/usb/core/driver.c (generic USB core, not Qualcomm-specific)
• Authorship inconsistency: Email in From: header (rhouji@qti.qualcomm.com) differs from Signed-off-by (rhoujik@qti.qualcomm.com)
• Code change: Adds printk("----------> %s qc-123 \n", __func__); which is:
  • Debug-only code with no functional purpose
  • Uses raw printk() instead of proper log level macro
  • Contains vendor-specific marker "qc-123"
  • Would never be accepted upstream
• Commit message: Explicitly states this is for "build verification" only, not a real functional change
• Subsystem mismatch: Subject references "arm64: driver:qcom: kaanapali" but changes generic USB core code

Verdict

Reject — This is a test commit masquerading as a FROMLIST patch. The FROMLIST prefix is fraudulent (no lore link), the subject doesn't match the code changed, authorship is inconsistent, and the code adds debug-only printk statements that would never be accepted upstream.

---

Overall Assessment

Both patches in this PR are test/debug commits that should never be merged into any production branch.

Critical Issues:

1. Patch 1: Non-descriptive subject, malformed Signed-off-by, adds meaningless debug text
2. Patch 2: Fraudulent FROMLIST prefix (no lore link), subject/code mismatch, authorship inconsistency, debug-only printk
3. Both patches: Add debug/test code with no functional value
4. Both patches: Would fail upstream review immediately

Final Summary

1. Lore link present: No — Patch 1 has no upstream claim; Patch 2 claims FROMLIST but provides no Link: tag
2. Lore link matches PR commits: N/A — No lore links to compare against
3. Upstream patch status: Not upstream — These are test commits that would be rejected immediately if posted
4. PR present in qcom-next: Not checked — These commits should not exist in any branch

Recommendation

Close this PR immediately. These are test commits that accidentally made it into a pull request. The author should:

• Delete these commits from their branch
• Never use FROMLIST prefix without a valid lore.kernel.org Link: tag
• Follow proper kernel commit message format (see Documentation/process/submitting-patches.rst)
• Remove all debug/test code before creating PRs

[qlijarvis]

PR #1413 — checker-log-analyzer

PR: #1413
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28353204643

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	3 errors, 4 warnings across 2 commits
dt-binding-check	⏭️	No devicetree binding changes
dtb-check	⏭️	No devicetree changes
sparse-check	✅	Passed
check-uapi-headers	✅	No UAPI header changes
check-patch-compliance	❌	Missing Link: tag in FROMLIST commit
tag-check	❌	Subject prefix required (not qcom-next/qcom-next-staging)
qcom-next-check	⚠️	FROMLIST: commit present (requires Link: tag)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1413 - test change / FROMLIST: arm64: driver:qcom: kaanapali: add dummy debug prints for kernel build verification
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28353204643

Checker	Result	Summary
checkpatch	❌	3 errors, 4 warnings across 2 commits
dt-binding-check	⏭️	No devicetree binding changes
dtb-check	⏭️	No devicetree changes
sparse-check	✅	Passed
check-uapi-headers	✅	No UAPI header changes
check-patch-compliance	❌	Missing Link: tag in FROMLIST commit
tag-check	❌	Subject prefix required (not qcom-next/qcom-next-staging)
qcom-next-check	⚠️	FROMLIST: commit present (requires Link: tag)

---

❌ checkpatch

Root cause: Multiple coding style violations and malformed Signed-off-by tags in both commits.

Failure details:

Commit 1 (68fa188):

ERROR: Unrecognized email address: 'Roopak Houji rhouji@qti.qualcomm.com'
#10: 
Signed-off-by: Roopak Houji rhouji@qti.qualcomm.com

WARNING: unnecessary whitespace before a quoted newline
#24: FILE: drivers/usb/core/driver.c:1086:
+	pr_info("%s: registered new interface driver %s , test_change \n",

CHECK: Alignment should match open parenthesis
#25: FILE: drivers/usb/core/driver.c:1087:
+	pr_info("%s: registered new interface driver %s , test_change \n",
 			usbcore_name, new_driver->name);

ERROR: Missing Signed-off-by: line by nominal patch author 'rhouji <rhouji@qti.qualcomm.com>'

68fa1889416c total: 2 errors, 1 warnings, 1 checks, 8 lines checked

Commit 2 (7dfc832):

WARNING: unnecessary whitespace before a quoted newline
#23: FILE: drivers/usb/core/driver.c:1088:
+	printk("----------> %s qc-123 \n", __func__);

ERROR: Missing Signed-off-by: line by nominal patch author 'rhouji <rhouji@qti.qualcomm.com>'

7dfc832cc72c total: 1 errors, 3 warnings, 0 checks, 7 lines checked

Fix:

1. Commit 1 - Fix Signed-off-by tag:

   • Current: Signed-off-by: Roopak Houji rhouji@qti.qualcomm.com
   • Should be: Signed-off-by: Roopak Houji <rhouji@qti.qualcomm.com> (add angle brackets)

2. Commit 1 - Fix whitespace before newline:

   • Remove space before \n in the pr_info string
   • Change: "... %s , test_change \n" → "... %s, test_change\n"

3. Commit 1 - Fix alignment:

   • Align the second line of pr_info with the opening parenthesis

4. Commit 2 - Fix Signed-off-by tag:

   • Current: Signed-off-by: Roopak houji <rhoujik@qti.qualcomm.com>
   • Should match author: Signed-off-by: rhouji <rhouji@qti.qualcomm.com>
   • Note: Email in commit 2 is different (rhoujik vs rhouji) - use consistent email

5. Commit 2 - Fix whitespace before newline:

   • Remove space before \n in the printk string
   • Change: "... qc-123 \n" → "... qc-123\n"

6. Commit 2 - Use pr_info instead of printk:

   • Replace printk(...) with pr_info(...) for consistency

Reproduce locally:

./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES --git 19b282f417584cfe14ce6a262122c51553d026ec..bcb619f6520cf126cce2cb39f1c46ce0f8ec3cac

---

❌ check-patch-compliance

Root cause: FROMLIST: commit (7dfc832) is missing the required Link: tag pointing to the upstream mailing list discussion.

Failure details:

Checking commit: FROMLIST: arm64: driver:qcom: kaanapali: add dummy debug prints for kernel build verification
No 'Link' found in commit message

Fix:

Add a Link: tag to the commit message of commit 2 (7dfc832) pointing to the lore.kernel.org URL where this patch was posted upstream. The Link: tag should be placed after the commit description and before the Signed-off-by tag.

Example format:

FROMLIST: arm64: driver:qcom: kaanapali: add dummy debug prints for kernel build verification

Add dummy debug prints in the usb driver to verify the kernel build and confirm
the updated code path is compiled successfully during build validation.

Link: https://lore.kernel.org/r/<message-id>
Signed-off-by: rhouji <rhouji@qti.qualcomm.com>

Note: If this patch has not actually been posted to an upstream mailing list, the FROMLIST: prefix is incorrect. Use UPSTREAM: only if the patch is already merged in mainline, or remove the prefix entirely for internal/downstream-only changes.

Reproduce locally:

# Check for Link: tag in FROMLIST commits
git log --format="%H %s" 19b282f41758..HEAD | grep "FROMLIST:" | while read sha subject; do
  git show $sha | grep -q "^Link:" || echo "Missing Link: in $sha"
done

---

Verdict

2 blockers must be fixed before merge:

1. checkpatch failures: Fix Signed-off-by tags (add angle brackets, use consistent email), remove whitespace before \n, fix alignment, and use pr_info instead of printk
2. check-patch-compliance failure: Add Link: tag to FROMLIST commit or remove FROMLIST: prefix if not posted upstream

Additional considerations:

• The changes appear to be test/debug code (test_change, qc-123) that may not be suitable for production
• Consider whether these debug prints should be in the final submission
• Ensure the FROMLIST: prefix is appropriate - only use if the patch is actually posted to an upstream mailing list