Fix probe failure on Shikra IQS board

[ayaan-anwar]

GPIO138 is a reserved GPIO, with its access protected by TZ. Remove it from ethernet1_default_state so that its probe doesn't fail due to Kernel access to GPIO138 being restricted. Also enable the TI PHY config (by removing it from prune.config) so that the ethernet interface is brought up properly with the DP83867 driver instead of the generic PHY driver.

CRs-Fixed: 4582518
QLIJIRA for commit 2: https://jira-dc.qualcomm.com/jira/browse/QLIJIRA-142

[qswat-orbit-external]

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4582518 on any of the following entities:

Entities:

• kernel.qli.2.0

CR: 4582518

Please ensure the CR has a change task associated with at least one of the entities for this branch.

[qswat-orbit-external]

Merge Check Failed: CR Not Eligible for Merge

CR 4582518 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4582518
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

[qlijarvis]

PR #761 — validate-patch

PR: #761

Verdict	Issues	Detailed Report
⚠️	7	Full report

Final Summary

Commit 1: prune.config: Enable the TI DP83867 PHY driver

1. Lore link present: No — vendor-specific config file (prune.config not in mainline)
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: Not upstream — prune.config is Qualcomm vendor-specific
4. PR present in qcom-next: Not checked — vendor-only config change

Commit 2: arm64: dts: qcom: shikra-iqs-evk: Remove GPIO138 from reserved ranges

1. Lore link present: No — shikra-iqs-evk.dts not found in mainline kernel
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: Not upstream — shikra-iqs-evk board is Qualcomm vendor-specific
4. PR present in qcom-next: Not checked — vendor-only DTS change

Overall Assessment:
Both commits appear to be vendor-specific changes for Qualcomm internal kernel tree. The changes are technically sound with clear commit messages explaining the rationale. Main issue is formatting (extra space in commit 2 subject). Consider using QCLINUX: prefix convention for vendor-only commits to clearly distinguish them from upstream-bound patches.

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #761 - Enable TI DP83867 PHY and fix GPIO138 reservation for Shikra IQS EVK
Upstream commit: N/A (vendor-only changes)
Verdict: ⚠️ PARTIAL

---

Commit 1: prune.config: Enable the TI DP83867 PHY driver

Commit Message

Check	Status	Note
Subject matches upstream	N/A	Vendor-only config file (prune.config)
Body preserves rationale	✅	Clear explanation of why the config is needed
Fixes tag present/correct	N/A	New enablement, not a fix
Authorship preserved	✅	Proper author and SOB present
Backport note (if applicable)	N/A	Not a backport

Diff

File	Status	Notes
arch/arm64/configs/prune.config	✅	Single line removal to enable DP83867_PHY driver

---

Commit 2: arm64: dts: qcom: shikra-iqs-evk: Remove GPIO138 from reserved ranges

Commit Message

Check	Status	Note
Subject matches upstream	⚠️	Extra space after [PATCH 2/2] in subject line
Body preserves rationale	✅	Detailed explanation of GPIO138 usage and pinctrl conflict
Fixes tag present/correct	⚠️	Missing Fixes: tag if this corrects a prior commit
Authorship preserved	✅	Proper author and SOB present
Backport note (if applicable)	N/A	Not a backport

Diff

File	Status	Notes
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts	✅	Removes GPIO138 from reserved ranges array

---

Issues

Commit 2 formatting:

• Subject line has extra whitespace: Subject: [PATCH 2/2] arm64: (two spaces after 2/2])
• Should be: Subject: [PATCH 2/2] arm64: (one space)

Missing Fixes: tag consideration:

• If GPIO138 was previously added to gpio-reserved-ranges in error, commit 2 should include a Fixes: tag referencing that commit
• If this is initial board enablement being corrected before merge, no Fixes: tag needed

No upstream links:

• Neither commit includes a Link: tag to lore.kernel.org
• Both files (prune.config, shikra-iqs-evk.dts) appear to be Qualcomm vendor-specific
• If these are vendor-only changes, they should ideally use QCLINUX: prefix in subject

---

Verdict

Merge with minor fix recommended: Fix the extra space in commit 2 subject line. Consider adding QCLINUX: prefix to both commits if these are vendor-only changes not intended for upstream submission. If commit 2 fixes a prior commit in the tree, add appropriate Fixes: tag.

---

Final Summary

Commit 1: prune.config: Enable the TI DP83867 PHY driver

1. Lore link present: No — vendor-specific config file (prune.config not in mainline)
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: Not upstream — prune.config is Qualcomm vendor-specific
4. PR present in qcom-next: Not checked — vendor-only config change

Commit 2: arm64: dts: qcom: shikra-iqs-evk: Remove GPIO138 from reserved ranges

1. Lore link present: No — shikra-iqs-evk.dts not found in mainline kernel
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: Not upstream — shikra-iqs-evk board is Qualcomm vendor-specific
4. PR present in qcom-next: Not checked — vendor-only DTS change

Overall Assessment:
Both commits appear to be vendor-specific changes for Qualcomm internal kernel tree. The changes are technically sound with clear commit messages explaining the rationale. Main issue is formatting (extra space in commit 2 subject). Consider using QCLINUX: prefix convention for vendor-only commits to clearly distinguish them from upstream-bound patches.

[qlijarvis]

PR #761 — checker-log-analyzer

PR: #761
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28027781253

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	0 errors, 0 warnings, 0 checks
dt-binding-check	⏭️	No changes in Documentation/devicetree/bindings
dtb-check	✅	Test passed
sparse-check	⏭️	Skipped (no C code changes)
check-uapi-headers	⏭️	Skipped (no UAPI changes)
check-patch-compliance	❌	Both commits missing required subject prefix
tag-check	N/A	Not applicable for this branch
qcom-next-check	N/A	Not applicable for this branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #761 - Enable TI DP83867 PHY driver and fix GPIO138 reservation for Shikra IQS EVK
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28027781253

Checker	Result	Summary
checkpatch	✅	0 errors, 0 warnings, 0 checks
dt-binding-check	⏭️	No changes in Documentation/devicetree/bindings
dtb-check	✅	Test passed
sparse-check	⏭️	Skipped (no C code changes)
check-uapi-headers	⏭️	Skipped (no UAPI changes)
check-patch-compliance	❌	Both commits missing required subject prefix
tag-check	N/A	Not applicable for this branch
qcom-next-check	N/A	Not applicable for this branch

❌ check-patch-compliance

Root cause: Both commits lack the required FROMLIST: or UPSTREAM: prefix in their subject lines.

Failure details:

Checking commit: prune.config: Enable the TI DP83867 PHY driver
Commit summary does not start with a required prefix

Checking commit:  arm64: dts: qcom: shikra-iqs-evk: Remove GPIO138 from reserved ranges
Commit summary does not start with a required prefix

Fix: Add the appropriate prefix to both commit subjects:

For commit 1 (bfb3dfe873386795d84f665061678bf1fc7243fa):

• Current: prune.config: Enable the TI DP83867 PHY driver
• Fixed: QCOM: prune.config: Enable the TI DP83867 PHY driver

For commit 2 (faa7eae1a69d8e7ea6d818de673697defd8491e4):

• Current: arm64: dts: qcom: shikra-iqs-evk: Remove GPIO138 from reserved ranges
• Fixed: QCOM: arm64: dts: qcom: shikra-iqs-evk: Remove GPIO138 from reserved ranges

Note: The second commit has an extra leading space in the subject line that should also be removed.

Reproduce locally:

git clone https://github.com/qualcomm-linux/kernel-checkers.git
cd kernel-checkers
./check-patch-compliance.sh --kernel-src /path/to/kernel --base c14585bb7b43b15841417db40e4d43ddbd77a247 --head faa7eae1a69d8e7ea6d818de673697defd8491e4

How to fix:

# Interactive rebase to edit both commits
git rebase -i c14585bb7b43b15841417db40e4d43ddbd77a247

# Mark both commits for 'reword', then update subjects with QCOM: prefix
# Alternatively, use git commit --amend for each commit

Verdict

1 blocker to fix: Both commits require the QCOM: subject prefix to pass check-patch-compliance. All other checkers passed or were correctly skipped.

[qlijarvis]

PR #761 — validate-patch

PR: #761

Verdict	Issues	Detailed Report
✅	1	Full report

Final Summary

PATCH 1/2 (prune.config):

1. Lore link present: No — vendor-specific config file; no lore link expected or required
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — vendor-only change (prune.config not in upstream)
4. PR present in qcom-next: Not checked — vendor-specific config enablement

PATCH 2/2 (shikra-iqs-evk DTS):

1. Lore link present: No — board DTS not found in upstream kernel tree; appears to be vendor-only
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: Not upstream — Shikra IQS EVK board file not present in mainline Linux
4. PR present in qcom-next: Not checked — vendor board enablement

Overall Assessment:
Both patches are vendor-specific enablement changes for Qualcomm Shikra IQS EVK hardware. They follow proper kernel commit message conventions, have clear technical rationale, and make focused changes. No upstream submission is expected for these patches as they target Qualcomm-specific infrastructure (prune.config) and a vendor development board not yet in mainline.

Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #761 - Enable TI DP83867 PHY and fix GPIO138 reservation for Shikra IQS EVK
Upstream commit: N/A (vendor-specific changes)
Verdict: ✅ PASS (vendor-only patches, properly formatted)

---

PATCH 1/2: prune.config: Enable the TI DP83867 PHY driver

Commit Message

Check	Status	Note
Subject matches upstream	N/A	Vendor-specific config file (prune.config)
Body preserves rationale	✅	Clear explanation: Shikra EVK boards need RGMII TI PHY driver
Fixes tag present/correct	N/A	Enablement patch, no bug fix
Authorship preserved	✅	Mohd Ayaan Anwar mohd.anwar@oss.qualcomm.com
Backport note (if applicable)	N/A	Not a backport

Diff

File	Status	Notes
arch/arm64/configs/prune.config	✅	Removes single line disabling CONFIG_DP83867_PHY; clean change

Analysis

• File context: prune.config is a Qualcomm vendor-specific kernel config fragment, not present in upstream Linux
• Change rationale: Enables TI DP83867 PHY driver needed for Shikra EVK RGMII Ethernet
• Technical correctness: Removing # CONFIG_DP83867_PHY is not set will allow the driver to be built
• Commit message quality: Concise, clear, follows kernel style conventions

---

PATCH 2/2: arm64: dts: qcom: shikra-iqs-evk: Remove GPIO138 from reserved ranges

Commit Message

Check	Status	Note
Subject matches upstream	✅	Follows kernel DTS convention: arm64: dts: qcom: board: description
Body preserves rationale	✅	Excellent explanation of problem (pinctrl rejection) and solution
Fixes tag present/correct	⚠️	Missing Fixes tag if this corrects a previous commit that added the reservation
Authorship preserved	✅	Mohd Ayaan Anwar mohd.anwar@oss.qualcomm.com
Backport note (if applicable)	N/A	Not a backport

Diff

File	Status	Notes
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts	✅	Removes <138 1> from gpio-reserved-ranges; clean, focused change

Analysis

• File context: Device tree for Shikra IQS EVK board (Qualcomm development board)
• Change rationale: GPIO138 is needed for RGMII1_RX_CTL on EMAC interface; reservation was blocking pinctrl configuration
• Technical correctness: Removing the reservation allows EMAC driver to claim the pin
• Commit message quality: Excellent - explains both the symptom (probe failure) and root cause (reserved range conflict)
• Potential improvement: Could add a Fixes: tag if this corrects a previous commit that incorrectly reserved GPIO138

---

Issues

• Minor: Patch 2/2 could benefit from a Fixes: tag if the GPIO138 reservation was added in a previous commit that can be identified. This would help with backporting and tracking the fix.

---

Verdict

Merge as-is. Both patches are vendor-specific changes for Qualcomm hardware, properly formatted with clear commit messages and clean diffs. The changes are technically sound and enable Ethernet functionality on Shikra IQS EVK boards.

---

Final Summary

PATCH 1/2 (prune.config):

1. Lore link present: No — vendor-specific config file; no lore link expected or required
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — vendor-only change (prune.config not in upstream)
4. PR present in qcom-next: Not checked — vendor-specific config enablement

PATCH 2/2 (shikra-iqs-evk DTS):

1. Lore link present: No — board DTS not found in upstream kernel tree; appears to be vendor-only
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: Not upstream — Shikra IQS EVK board file not present in mainline Linux
4. PR present in qcom-next: Not checked — vendor board enablement

Overall Assessment:
Both patches are vendor-specific enablement changes for Qualcomm Shikra IQS EVK hardware. They follow proper kernel commit message conventions, have clear technical rationale, and make focused changes. No upstream submission is expected for these patches as they target Qualcomm-specific infrastructure (prune.config) and a vendor development board not yet in mainline.

[qlijarvis]

PR #761 — checker-log-analyzer

PR: #761
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28029867943

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	No style issues detected
dt-binding-check	⏭️	Skipped - no binding changes
dtb-check	✅	Device tree validation passed
sparse-check	⏭️	Skipped - no C code changes
check-uapi-headers	⏭️	Skipped - no UAPI changes
check-patch-compliance	❌	FAILED - Missing required subject prefix
tag-check	N/A	Not applicable for qcom-6.18.y branch
qcom-next-check	N/A	Not applicable for qcom-6.18.y branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #761 - Enable TI DP83867 PHY driver and fix GPIO138 reservation for Shikra IQS EVK
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28029867943

Checker	Result	Summary
checkpatch	✅	No style issues detected
dt-binding-check	⏭️	Skipped - no binding changes
dtb-check	✅	Device tree validation passed
sparse-check	⏭️	Skipped - no C code changes
check-uapi-headers	⏭️	Skipped - no UAPI changes
check-patch-compliance	❌	FAILED - Missing required subject prefix
tag-check	N/A	Not applicable for qcom-6.18.y branch
qcom-next-check	N/A	Not applicable for qcom-6.18.y branch

❌ check-patch-compliance

Root cause: Both commits lack the required subject prefix (UPSTREAM:, FROMLIST:, BACKPORT:, or INTERNAL:) mandated by Qualcomm Linux kernel commit message policy.

Failure details:

2026-06-23T13:45:39.6904632Z Checking commit: prune.config: Enable the TI DP83867 PHY driver
2026-06-23T13:45:39.6920713Z Commit summary does not start with a required prefix

2026-06-23T13:45:39.6971268Z Checking commit: arm64: dts: qcom: shikra-iqs-evk: Remove GPIO138 from reserved ranges
2026-06-23T13:45:39.6987989Z Commit summary does not start with a required prefix

Fix: Add the appropriate prefix to both commit subjects. Since these are internal Qualcomm-specific changes (not from upstream or mailing lists), use the INTERNAL: prefix:

Commit 1: Change subject from:

prune.config: Enable the TI DP83867 PHY driver

to:

INTERNAL: prune.config: Enable the TI DP83867 PHY driver

Commit 2: Change subject from:

arm64: dts: qcom: shikra-iqs-evk: Remove GPIO138 from reserved ranges

to:

INTERNAL: arm64: dts: qcom: shikra-iqs-evk: Remove GPIO138 from reserved ranges

Reproduce locally:

cd /path/to/kernel
git log --oneline -2
# Verify subjects lack prefix

# To fix, use interactive rebase:
git rebase -i HEAD~2
# Mark both commits as 'reword', then add INTERNAL: prefix to each subject

Verdict

1 blocker to fix: Both commits must be amended to include the INTERNAL: subject prefix before merging. All other checkers passed successfully.

[qlijarvis]

PR #761 — validate-patch

PR: #761

Verdict	Issues	Detailed Report
⚠️	0	Full report

Final Summary

Commit 1/2 (prune.config):

1. Lore link present: No — vendor-only config change; no lore link expected or required
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — vendor-only change, not posted upstream
4. PR present in qcom-next: Not checked — vendor-only commit

Commit 2/2 (FROMLIST DTS):

1. Lore link present: Yes — Link: https://lore.kernel.org/netdev/20260612-shikra_ethernet-v1-9-f0f4a1d19929@oss.qualcomm.com/
2. Lore link matches PR commits: Cannot verify — lore link is inaccessible (future date: 2026-06-12, current date: 2026-06-23; likely test scenario or incorrect date)
3. Upstream patch status: Unknown — cannot fetch from lore to determine if merged, in review, or pending
4. PR present in qcom-next: Not checked — cannot verify without accessible upstream reference

Action required: Verify the lore link is correct and accessible. If the patch has been posted upstream, ensure the Link: tag points to a valid, fetchable message-ID. Consider adding a Fixes: tag if this resolves a specific regression.

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #761
Upstream commit: https://lore.kernel.org/netdev/20260612-shikra_ethernet-v1-9-f0f4a1d19929@oss.qualcomm.com/ (commit 2/2 only)
Verdict: ⚠️ PARTIAL

---

Commit 1/2: prune.config: Enable the TI DP83867 PHY driver

Commit Message

Check	Status	Note
Subject matches upstream	N/A	Vendor-only config change
Body preserves rationale	✅	Clear explanation of why DP83867_PHY is needed
Fixes tag present/correct	N/A	Not a bug fix
Authorship preserved	✅	Mohd Ayaan Anwar
Backport note (if applicable)	N/A	Vendor-only change

Diff

File	Status	Notes
arch/arm64/configs/prune.config	✅	Removes CONFIG_DP83867_PHY disable line to enable driver

Issues

• None for this vendor-only commit

---

Commit 2/2: FROMLIST: arm64: dts: qcom: shikra-iqs: Remove GPIO138 from emac1 default state

Commit Message

Check	Status	Note
Subject matches upstream	⚠️	Subject is truncated; full upstream subject likely longer
Body preserves rationale	✅	Explains GPIO138 is TZ-protected and causes probe failure
Fixes tag present/correct	⚠️	No Fixes tag; may be needed if fixing a regression
Authorship preserved	✅	Mohd Ayaan Anwar
Backport note (if applicable)	✅	FROMLIST: prefix correctly indicates patch from mailing list

Diff

File	Status	Notes
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts	⚠️	Cannot verify against upstream (lore link inaccessible)

Issues

• Lore link inaccessible: The Link: tag points to a future date (2026-06-12) which cannot be fetched for verification
• Subject truncation: The subject line appears truncated in the patch ("Remove GPIO138" without "from emac1 default state" visible in short log)
• Missing Fixes tag: If this fixes a probe failure introduced by an earlier commit, a Fixes: tag should be present
• Link tag format: The Link: tag should typically appear after all other tags (Reviewed-by, Tested-by, etc.) and before Signed-off-by in upstream convention, but here it appears before Signed-off-by which is acceptable for FROMLIST

---

Verdict

Commit 1/2 (prune.config): ✅ PASS — Vendor-only config change with clear rationale. No upstream comparison needed.

Commit 2/2 (FROMLIST DTS): ⚠️ PARTIAL — Cannot verify diff faithfulness due to inaccessible lore link. Commit message structure is acceptable but may be missing a Fixes tag if this addresses a regression.

Overall recommendation:

• Commit 1/2 can merge as-is
• Commit 2/2 needs verification once the upstream patch is accessible, and should add a Fixes: tag if it resolves a probe failure introduced by a specific earlier commit

---

Final Summary

Commit 1/2 (prune.config):

1. Lore link present: No — vendor-only config change; no lore link expected or required
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — vendor-only change, not posted upstream
4. PR present in qcom-next: Not checked — vendor-only commit

Commit 2/2 (FROMLIST DTS):

1. Lore link present: Yes — Link: https://lore.kernel.org/netdev/20260612-shikra_ethernet-v1-9-f0f4a1d19929@oss.qualcomm.com/
2. Lore link matches PR commits: Cannot verify — lore link is inaccessible (future date: 2026-06-12, current date: 2026-06-23; likely test scenario or incorrect date)
3. Upstream patch status: Unknown — cannot fetch from lore to determine if merged, in review, or pending
4. PR present in qcom-next: Not checked — cannot verify without accessible upstream reference

Action required: Verify the lore link is correct and accessible. If the patch has been posted upstream, ensure the Link: tag points to a valid, fetchable message-ID. Consider adding a Fixes: tag if this resolves a specific regression.

[qlijarvis]

PR #761 — checker-log-analyzer

PR: #761
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28046175371

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	All commits pass coding style checks
dt-binding-check	⏭️	Skipped - no DT binding changes
dtb-check	✅	Device tree validation passed
sparse-check	⏭️	Skipped - no C code changes
check-uapi-headers	⏭️	Skipped - no UAPI header changes
check-patch-compliance	❌	2 compliance violations detected
tag-check	N/A	Not applicable for qcom-6.18.y branch
qcom-next-check	N/A	Not applicable for qcom-6.18.y branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #761 - Enable TI DP83867 PHY driver and fix Shikra GPIO138 issue
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28046175371

Checker	Result	Summary
checkpatch	✅	All commits pass coding style checks
dt-binding-check	⏭️	Skipped - no DT binding changes
dtb-check	✅	Device tree validation passed
sparse-check	⏭️	Skipped - no C code changes
check-uapi-headers	⏭️	Skipped - no UAPI header changes
check-patch-compliance	❌	2 compliance violations detected
tag-check	N/A	Not applicable for qcom-6.18.y branch
qcom-next-check	N/A	Not applicable for qcom-6.18.y branch

---

❌ check-patch-compliance

Root cause: Two compliance policy violations detected by the patch compliance checker.

Failure details:

Issue 1 - Commit bfb3dfe:

Checking commit: prune.config: Enable the TI DP83867 PHY driver
Commit summary does not start with a required prefix

The first commit modifies arch/arm64/configs/prune.config but lacks a required subject prefix. For Qualcomm kernel branches, config file changes typically require a prefix like FROMLIST:, UPSTREAM:, BACKPORT:, or QCOM: depending on the origin of the change.

Issue 2 - Commit c94f725:

Checking commit: FROMLIST: arm64: dts: qcom: shikra-iqs: Remove GPIO138 from emac1 default state
Change is different from the one mentioned in Link

The second commit has a FROMLIST: prefix and includes a Link tag pointing to:

Link: https://lore.kernel.org/netdev/20260612-shikra_ethernet-v1-9-f0f4a1d19929@oss.qualcomm.com/

However, the checker detected that the actual patch content differs from what was posted to the mailing list at that URL. This violates the FROMLIST policy, which requires that patches match their upstream submission exactly (except for context adjustments).

Fix:

For Issue 1 (prune.config commit):

• If this is a Qualcomm-specific configuration change, add the QCOM: prefix:

  QCOM: prune.config: Enable the TI DP83867 PHY driver
  

• If this change is being prepared for upstream submission, use FROMLIST: and include a Link tag to the mailing list submission
• If this is a local/internal change not intended for upstream, use an appropriate internal prefix per your team's conventions

For Issue 2 (FROMLIST commit):

• Compare the local patch with the upstream submission at the Link URL
• Identify what differs (likely the removal of GPIO138 from the pin list)
• Either:
  1. Update the patch to match the upstream version exactly, OR
  2. If intentional differences exist, change the prefix from FROMLIST: to BACKPORT: or QCOM: and explain the deviation in the commit message

Reproduce locally:

cd /path/to/kernel
git fetch origin qcom-6.18.y
git checkout qcom-6.18.y

# Fetch the PR
git fetch origin pull/761/head:pr-761
git checkout pr-761

# Run the compliance checker
bash /path/to/kernel-checkers/check-patch-compliance.sh \
  --kernel-src . \
  --base origin/qcom-6.18.y \
  --head HEAD

---

Verdict

2 blockers must be fixed before merge:

1. Add required subject prefix to the prune.config commit
2. Resolve FROMLIST mismatch - either sync with upstream or change prefix to reflect local modifications

All other checkers passed successfully. Once these two compliance issues are addressed, the PR will be ready for merge.

[ayaan-anwar]

qli-2.0 GA Critical Fix

[ayaan-anwar]

Validation result:

1. CQS - boot up, ethernet0 pings
2. IQS - boot up, ethernet0 pings, ethernet1 tx

Without this PR, IQS probe for ethernet will fail due to GPIO138 being a reserved GPIO (introduced by 234030f).

[qlijarvis]

PR #761 — validate-patch

PR: #761

Verdict	Issues	Detailed Report
⚠️	0	Full report

Final Summary

1. Lore link present:

   • Commit 1: No — QCLINUX prefix; no lore link expected or required
   • Commit 2: Yes — https://lore.kernel.org/netdev/20260612-shikra_ethernet-v1-9-f0f4a1d19929@oss.qualcomm.com/

2. Lore link matches PR commits:

   • Commit 1: N/A — no lore link to compare against
   • Commit 2: Cannot verify — network access restricted; manual verification required

3. Upstream patch status:

   • Commit 1: N/A — vendor-only change, not posted upstream
   • Commit 2: Cannot verify — FROMLIST indicates under review; network access required to check acceptance status

4. PR present in qcom-next:

   • Commit 1: Not checked — QCLINUX vendor-only commit
   • Commit 2: Not checked — cannot access kernel tree per task constraints

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #761
Commits: 2 (1 QCLINUX vendor commit, 1 FROMLIST upstream commit)
Verdict: ⚠️ PARTIAL — Cannot verify FROMLIST commit against upstream due to network restrictions

---

Commit 1/2: QCLINUX: prune.config: Enable the TI DP83867 PHY driver

Type: Vendor-only (QCLINUX)
Upstream commit: N/A

Commit Message

Check	Status	Note
Subject format	✅	Proper QCLINUX prefix, clear and concise
Body preserves rationale	✅	Explains Shikra EVK RGMII TI PHY requirement
Fixes tag present/correct	N/A	Not a fix, feature enablement
Authorship preserved	✅	Mohd Ayaan Anwar mohd.anwar@oss.qualcomm.com
Backport note	N/A	Vendor-only commit

Diff

File	Status	Notes
arch/arm64/configs/prune.config	✅	Removes single line # CONFIG_DP83867_PHY is not set to enable driver

Issues

None detected.

---

Commit 2/2: FROMLIST: arm64: dts: qcom: shikra-iqs: Remove GPIO138 from emac1 default state

Type: FROMLIST (pending upstream)
Upstream link: https://lore.kernel.org/netdev/20260612-shikra_ethernet-v1-9-f0f4a1d19929@oss.qualcomm.com/
Upstream commit: Cannot verify (network restricted)

Commit Message

Check	Status	Note
Subject matches upstream	⚠️	Cannot verify — network access restricted
Body preserves rationale	✅	Clear explanation: GPIO138 is TZ-protected, causes probe failure
Fixes tag present/correct	N/A	Not marked as a fix
Authorship preserved	⚠️	Cannot verify against upstream — appears correct
Backport note	N/A	FROMLIST, not backport
Link tag present	✅	Proper lore.kernel.org link included

Diff

File	Status	Notes
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts	⚠️	Removes "gpio138" from pins array; cannot verify against upstream

Issues

• Cannot verify diff faithfulness: Network restrictions prevent fetching upstream patch from lore.kernel.org
• Subject line truncated: Full subject is "Remove GPIO138 from emac1 default state" but git format-patch may have wrapped it
• Lore link date: Link references 2026-06-12, which is 12 days before PR date (2026-06-23); this is plausible for a FROMLIST patch

---

Overall Assessment

Commit 1 (QCLINUX) — ✅ PASS

• Vendor-only commit follows expected conventions
• Clear rationale for enabling DP83867 PHY driver
• Diff is minimal and focused
• No upstream validation required

Commit 2 (FROMLIST) — ⚠️ PARTIAL

• Proper FROMLIST prefix and lore link present
• Commit message is clear and well-structured
• Limitation: Cannot verify diff matches upstream due to network restrictions
• Recommendation: Manual verification required by reviewer with network access

---

Verdict

⚠️ PARTIAL VALIDATION — Commit 1 passes all checks. Commit 2 requires manual verification against lore.kernel.org link due to environment network restrictions. The commit message structure and diff format appear correct, but faithfulness to upstream cannot be confirmed.

---

Final Summary

1. Lore link present:

   • Commit 1: No — QCLINUX prefix; no lore link expected or required
   • Commit 2: Yes — https://lore.kernel.org/netdev/20260612-shikra_ethernet-v1-9-f0f4a1d19929@oss.qualcomm.com/

2. Lore link matches PR commits:

   • Commit 1: N/A — no lore link to compare against
   • Commit 2: Cannot verify — network access restricted; manual verification required

3. Upstream patch status:

   • Commit 1: N/A — vendor-only change, not posted upstream
   • Commit 2: Cannot verify — FROMLIST indicates under review; network access required to check acceptance status

4. PR present in qcom-next:

   • Commit 1: Not checked — QCLINUX vendor-only commit
   • Commit 2: Not checked — cannot access kernel tree per task constraints

[qlijarvis]

PR #761 — checker-log-analyzer

PR: #761
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28086504188

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	All commits pass coding style checks
dt-binding-check	⏭️	Skipped - no DT binding changes
dtb-check	✅	DTB validation passed for shikra-iqs-evk
sparse-check	⏭️	Skipped - no C code changes
check-uapi-headers	⏭️	Skipped - no UAPI header changes
check-patch-compliance	❌	2 compliance violations detected
tag-check	N/A	Not applicable for qcom-6.18.y branch
qcom-next-check	N/A	Not applicable for qcom-6.18.y branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #761 - Enable TI DP83867 PHY driver and fix Shikra GPIO138 issue
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28086504188

Checker	Result	Summary
checkpatch	✅	All commits pass coding style checks
dt-binding-check	⏭️	Skipped - no DT binding changes
dtb-check	✅	DTB validation passed for shikra-iqs-evk
sparse-check	⏭️	Skipped - no C code changes
check-uapi-headers	⏭️	Skipped - no UAPI header changes
check-patch-compliance	❌	2 compliance violations detected
tag-check	N/A	Not applicable for qcom-6.18.y branch
qcom-next-check	N/A	Not applicable for qcom-6.18.y branch

❌ check-patch-compliance

Root cause: Two compliance violations in commit metadata and patch integrity.

Failure details:

Commit 1: d8aacdf ("QCLINUX: prune.config: Enable the TI DP83867 PHY driver")

Checking commit: QCLINUX: prune.config: Enable the TI DP83867 PHY driver
Commit summary does not start with a required prefix

Commit 2: fe7238c ("FROMLIST: arm64: dts: qcom: shikra-iqs: Remove GPIO138 from emac1 default state")

Checking commit: FROMLIST: arm64: dts: qcom: shikra-iqs: Remove GPIO138 from emac1 default state
Change is different from the one mentioned in Link

Link referenced: https://lore.kernel.org/netdev/20260612-shikra_ethernet-v1-9-f0f4a1d19929@oss.qualcomm.com/

Fix:

For Commit 1 (QCLINUX prefix issue):

• The QCLINUX: prefix is not a recognized upstream-style prefix for the qcom-6.18.y branch
• Option A (Recommended): Change prefix to match the file type: arm64: configs: prune: Enable TI DP83867 PHY driver
• Option B: If this is truly a Qualcomm-internal change, ensure the branch policy allows QCLINUX: prefix, or use no prefix at all

For Commit 2 (FROMLIST patch mismatch):

• The checker detected that the local patch differs from the upstream lore link
• This typically means:
  1. The patch was modified after being posted to the mailing list, OR
  2. The Link: tag points to the wrong version/patch in the series
• Fix: Either:
  • Update the Link: tag to point to the correct version that matches this exact change
  • If the patch was intentionally modified, add a note in the commit message explaining the delta (e.g., "[ Qualcomm: adapted for qcom-6.18.y baseline ]")
  • Verify the lore link points to patch ci: Fix: add bash shell to actions & use pull_request_target only for premerge #9 in the series and that GPIO138 removal is the only change

Reproduce locally:

cd /path/to/kernel
git fetch origin qcom-6.18.y
git checkout qcom-6.18.y
git fetch origin pull/761/head:pr-761
git checkout pr-761

# Run compliance check
./scripts/check-patch-compliance.sh --base origin/qcom-6.18.y --head HEAD

Verdict

2 blockers must be fixed before merge:

1. Fix commit subject prefix for the QCLINUX commit (use standard kernel subsystem prefix)
2. Resolve FROMLIST patch mismatch - either update Link tag or document intentional changes

[sgaud-quic]

@ayaan-anwar please get approval on the PR

[sgaud-quic]

@ayaan-anwar jira is not approved :

https://jira-dc.qualcomm.com/jira/browse/QLIJIRA-142

[qlijarvis]

PR #761 — validate-patch

PR: #761

Verdict	Issues	Detailed Report
⚠️	0	Full report

Final Summary

1. Lore link present:

   • Commit 1: No — QCLINUX: prefix; no lore link expected or required
   • Commit 2: Yes — https://lore.kernel.org/netdev/20260612-shikra_ethernet-v1-9-f0f4a1d19929@oss.qualcomm.com/ (v1 series, patch 9, posted 2026-06-12)

2. Lore link matches PR commits:

   • Commit 1: N/A — no lore link to compare against
   • Commit 2: Cannot verify — network access restricted; lore.kernel.org unreachable. Message-ID format is valid; manual verification recommended.

3. Upstream patch status:

   • Commit 1: N/A — vendor-only change, not posted upstream
   • Commit 2: In review — PENDING: prefix indicates upstream submission in progress (posted 11 days before PR creation)

4. PR present in qcom-next:

   • Commit 1: Not checked — QCLINUX: vendor-only commit
   • Commit 2: Not checked — PENDING: patch still under upstream review; premature to check qcom-next

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #761
Upstream commit: N/A (Commit 1: vendor-only; Commit 2: PENDING upstream review)
Verdict: ⚠️ PARTIAL

---

Commit 1/2: QCLINUX: prune.config: Enable the TI DP83867 PHY driver

Commit Message

Check	Status	Note
Subject matches upstream	N/A	QCLINUX: vendor-only commit
Body preserves rationale	✅	Clear explanation: Shikra EVK boards need RGMII TI PHY
Fixes tag present/correct	N/A	Not a fix; feature enablement
Authorship preserved	✅	Mohd Ayaan Anwar mohd.anwar@oss.qualcomm.com
Backport note (if applicable)	N/A	Vendor-only change

Diff

File	Status	Notes
arch/arm64/configs/prune.config:96	✅	Removes # CONFIG_DP83867_PHY is not set line cleanly

Issues

None. Vendor-only config change is well-justified and correctly formatted.

---

Commit 2/2: PENDING: arm64: dts: qcom: shikra-iqs: Remove GPIO138 from emac1 default state

Commit Message

Check	Status	Note
Subject matches upstream	⚠️	Cannot verify; lore.kernel.org unreachable (network restricted)
Body preserves rationale	✅	Clear: GPIO138 is TZ-protected, causes probe failure
Fixes tag present/correct	⚠️	Missing Fixes tag; should reference commit that added GPIO138
Authorship preserved	✅	Mohd Ayaan Anwar mohd.anwar@oss.qualcomm.com
Backport note (if applicable)	N/A	PENDING: not yet upstream

Diff

File	Status	Notes
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:542	✅	Removes "gpio138" from pins array; formatting preserved

Issues

• Missing Fixes tag: This patch corrects a probe failure caused by an earlier commit that added GPIO138 to the pinctrl configuration. A Fixes: tag should reference the commit that introduced ethernet1_defaults or added GPIO138 to the pin list.
• Lore link verification blocked: Network access is restricted; cannot fetch upstream patch from lore.kernel.org to verify diff faithfulness. The Link tag format and message-ID structure are correct (dated 2026-06-12, v1 series, patch 9).

---

Verdict

Commit 1 (QCLINUX): ✅ Merge as-is — vendor-only config change is correctly formatted and justified.

Commit 2 (PENDING): ⚠️ Acceptable with caveat — the diff and commit message are well-formed, but a Fixes: tag should be added to reference the commit that introduced GPIO138 in the pinctrl node. Without network access, upstream patch faithfulness cannot be verified; manual review against the lore series is recommended before merge.

---

Final Summary

1. Lore link present:

   • Commit 1: No — QCLINUX: prefix; no lore link expected or required
   • Commit 2: Yes — https://lore.kernel.org/netdev/20260612-shikra_ethernet-v1-9-f0f4a1d19929@oss.qualcomm.com/ (v1 series, patch 9, posted 2026-06-12)

2. Lore link matches PR commits:

   • Commit 1: N/A — no lore link to compare against
   • Commit 2: Cannot verify — network access restricted; lore.kernel.org unreachable. Message-ID format is valid; manual verification recommended.

3. Upstream patch status:

   • Commit 1: N/A — vendor-only change, not posted upstream
   • Commit 2: In review — PENDING: prefix indicates upstream submission in progress (posted 11 days before PR creation)

4. PR present in qcom-next:

   • Commit 1: Not checked — QCLINUX: vendor-only commit
   • Commit 2: Not checked — PENDING: patch still under upstream review; premature to check qcom-next

[qlijarvis]

PR #761 — checker-log-analyzer

PR: #761
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28098061320

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	No style issues detected
dt-binding-check	⏭️	Skipped - no binding changes
dtb-check	✅	DTB validation passed
sparse-check	⏭️	Skipped - no C code changes
check-uapi-headers	⏭️	Skipped - no UAPI changes
check-patch-compliance	❌	Subject prefix validation failed
tag-check	N/A	Not applicable for qcom-6.18.y
qcom-next-check	N/A	Not applicable for qcom-6.18.y

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #761 - Enable TI DP83867 PHY driver and remove GPIO138 from emac1
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28098061320

Checker	Result	Summary
checkpatch	✅	No style issues detected
dt-binding-check	⏭️	Skipped - no binding changes
dtb-check	✅	DTB validation passed
sparse-check	⏭️	Skipped - no C code changes
check-uapi-headers	⏭️	Skipped - no UAPI changes
check-patch-compliance	❌	Subject prefix validation failed
tag-check	N/A	Not applicable for qcom-6.18.y
qcom-next-check	N/A	Not applicable for qcom-6.18.y

---

❌ check-patch-compliance

Root cause: Both commits use non-standard subject prefixes (QCLINUX: and PENDING:) that are not recognized by the checker.

Failure details:

Checking commit: QCLINUX: prune.config: Enable the TI DP83867 PHY driver
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: dts: qcom: shikra-iqs: Remove GPIO138 from emac1 default state
Commit summary does not start with a required prefix

Analysis:

The check-patch-compliance checker validates that commit subjects follow Qualcomm Linux kernel conventions. The checker expects one of these prefixes:

• UPSTREAM: - for patches already merged upstream
• FROMLIST: - for patches posted to upstream mailing lists
• BACKPORT: - for backported patches
• Standard kernel subsystem prefixes (e.g., arm64: dts:, net: phy:)

Issues identified:

1. Commit 1 uses QCLINUX: prefix - This is a Qualcomm-internal prefix that should only be used for truly internal-only changes. Since this commit enables a standard upstream PHY driver (TI DP83867), it should use a standard kernel subsystem prefix instead.

2. Commit 2 uses PENDING: prefix - This prefix is not recognized by the checker. The commit references a lore.kernel.org link, suggesting it's related to an upstream submission. It should use either FROMLIST: (if posted upstream but not yet merged) or a standard subsystem prefix.

Fix:

For Commit 1 - Change subject from:

QCLINUX: prune.config: Enable the TI DP83867 PHY driver

to:

arm64: configs: prune: Enable TI DP83867 PHY driver

For Commit 2 - Since the commit references a lore link (https://lore.kernel.org/netdev/20260612-shikra_ethernet-v1-9-f0f4a1d19929@oss.qualcomm.com/), change subject from:

PENDING: arm64: dts: qcom: shikra-iqs: Remove GPIO138 from emac1 default state

to:

FROMLIST: arm64: dts: qcom: shikra-iqs: Remove GPIO138 from emac1 default state

Reproduce locally:

cd /path/to/kernel
git log --oneline -2 HEAD
# Run the compliance checker
bash kernel-checkers/check-patch-compliance.sh --kernel-src . --base <base-sha> --head <head-sha>

---

Verdict

1 blocker to fix: Both commits need subject prefix corrections to pass check-patch-compliance. All other checkers passed successfully. Once the commit subjects are updated with proper prefixes, the PR will be ready to merge.