FROMLIST: drm/msm/dp: return 0 from audio_prepare when cable is disconnected

[kumarsingh-art]

PipeWire treats a non-zero return from prepare as fatal, marking the DP audio device as a dummy sink when the cable is unplugged. The active_stream_cnt guard already prevents any unclocked hardware access, so return success instead of -EINVAL when the link is not active.

Link: https://lore.kernel.org/all/20260616151252.3599089-2-kumar.singh@oss.qualcomm.com/
CRs-Fixed: 4582751

[qswat-orbit-external]

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4582751 on any of the following entities:

Entities:

• kernel.qli.2.0

CR: 4582751

Please ensure the CR has a change task associated with at least one of the entities for this branch.

[qlijarvis]

PR #764 — validate-patch

PR: #764

Verdict	Issues	Detailed Report
❌	3	Full report

Final Summary

1. Lore link present: Yes - but unreachable (returns empty response; future date 2026-06-16)
2. Lore link matches PR commits: Cannot verify - lore link returns no content
3. Upstream patch status: Cannot determine - lore archive has no record of this message-ID
4. PR present in qcom-next: Not checked - validation blocked by authorship issue

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #764 - drm/msm/dp: return 0 from audio_prepare when cable is disconnected
Upstream commit: https://lore.kernel.org/all/20260616151252.3599089-2-kumar.singh@oss.qualcomm.com/ (unreachable)
Verdict: ❌ FAIL

Commit Message

Check	Status	Note
Subject matches upstream	⚠️	Cannot verify - lore link unreachable (future date)
Body preserves rationale	✅	Clear explanation of PipeWire behavior and fix rationale
Fixes tag present/correct	❌	Missing Fixes: tag for regression fix
Authorship preserved	❌	Author name format incorrect: "kumar.singh" should be "Kumar Singh" or proper full name
Backport note (if applicable)	N/A	FROMLIST prefix indicates pending upstream submission

Diff

File	Status	Notes
drivers/gpu/drm/msm/dp/dp_audio.c	✅	Logic change is clean: removes -EINVAL assignment, returns 0 via goto end

Issues

Critical:

• Author name format violation: "kumar.singh" is not a valid author name format. Kernel convention requires proper capitalized full name (e.g., "Kumar Singh"). The email kumar.singh@oss.qualcomm.com is acceptable, but the name field must be a real human name, not a username.

Major:

• Missing Fixes: tag: This patch fixes a behavioral regression where PipeWire treats non-zero returns as fatal. If this fixes a previous commit that introduced the -EINVAL return, a Fixes: tag should be present.

Minor:

• Lore link unreachable: The Link: URL points to a future date (2026-06-16) and returns no content. This suggests either:
  • The patch has not actually been posted to the mailing list yet (FROMLIST is premature)
  • The message-ID is incorrect
  • The date in the test environment is inconsistent

Verdict

Reject - Author name must be corrected to proper format before merge. Consider adding Fixes: tag if this addresses a regression. Verify lore link is valid before using FROMLIST prefix.

Final Summary

1. Lore link present: Yes - but unreachable (returns empty response; future date 2026-06-16)
2. Lore link matches PR commits: Cannot verify - lore link returns no content
3. Upstream patch status: Cannot determine - lore archive has no record of this message-ID
4. PR present in qcom-next: Not checked - validation blocked by authorship issue

[qlijarvis]

PR #764 — checker-log-analyzer

PR: #764
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28042659110

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	No style issues detected
dt-binding-check	⏭️	Skipped - no DT binding changes
dtb-check	⏭️	Skipped - no devicetree changes
sparse-check	✅	No sparse warnings
check-uapi-headers	✅	No UAPI header changes
check-patch-compliance	❌	FAILED - Author mismatch + patch content differs from upstream
tag-check	N/A	Not applicable (FROMLIST prefix present)
qcom-next-check	✅	FROMLIST prefix correct

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #764 - FROMLIST: drm/msm/dp: return 0 from audio_prepare when cable is disconnected
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28042659110

Checker	Result	Summary
checkpatch	✅	No style issues detected
dt-binding-check	⏭️	Skipped - no DT binding changes
dtb-check	⏭️	Skipped - no devicetree changes
sparse-check	✅	No sparse warnings
check-uapi-headers	✅	No UAPI header changes
check-patch-compliance	❌	FAILED - Author mismatch + patch content differs from upstream
tag-check	N/A	Not applicable (FROMLIST prefix present)
qcom-next-check	✅	FROMLIST prefix correct

---

❌ check-patch-compliance

Root cause: Two compliance violations detected when comparing the PR commit against the upstream lore link.

Failure details:

2026-06-23T17:15:35.4033394Z Change is different from the one mentioned in Link
2026-06-23T17:15:35.4085352Z Author mismatch:
2026-06-23T17:15:35.4085780Z   Original author: Kumar Anurag <kumar.singh@oss.qualcomm.com>
2026-06-23T17:15:35.4086455Z   Commit author : kumar.singh <kumar.singh@oss.qualcomm.com>

Issue 1: Author Name Format

• Expected: Kumar Anurag <kumar.singh@oss.qualcomm.com>
• Actual: kumar.singh <kumar.singh@oss.qualcomm.com>
• The author name must match the upstream patch exactly, including proper capitalization and full name format.

Issue 2: Patch Content Mismatch

• The checker detected that the patch content in this PR differs from the upstream patch at the lore link: https://lore.kernel.org/all/20260616151252.3599089-2-kumar.singh@oss.qualcomm.com/
• This could indicate:
  • Additional changes were made beyond the upstream patch
  • The patch was modified during cherry-pick/backport
  • The wrong lore link was referenced

Fix:

1. Fix the author name:

   git commit --amend --author="Kumar Anurag <kumar.singh@oss.qualcomm.com>"

2. Verify patch content matches upstream:

   • Download the original patch from lore:

     curl -L "https://lore.kernel.org/all/20260616151252.3599089-2-kumar.singh@oss.qualcomm.com/raw" -o upstream.patch

   • Compare with your local commit:

     git format-patch -1 HEAD --stdout > local.patch
     diff -u upstream.patch local.patch

   • If differences exist, either:
     • Cherry-pick the exact upstream patch, OR
     • If intentional changes were made, document them in the commit message

3. Force-push the corrected commit:

   git push --force-with-lease origin <branch-name>

Reproduce locally:

cd /path/to/kernel
git fetch origin pull/764/head:pr-764
git checkout pr-764
bash kernel-checkers/check-patch-compliance.sh --kernel-src . --base c359ce8cd46f86080e611e852c4c5d5d45028081 --head 554f3dbce37ce1ae715b5373bfbe92925a20b557

---

Verdict

2 blockers must be fixed before merge:

1. Author name must be corrected to Kumar Anurag <kumar.singh@oss.qualcomm.com>
2. Patch content must exactly match the upstream lore link, or differences must be explained in the commit message

All other checkers passed successfully. Once the author and patch compliance issues are resolved, this PR will be ready to merge.

[qswat-orbit-external]

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4582751 on any of the following entities:

Entities:

• kernel.qli.2.0

CR: 4582751

Please ensure the CR has a change task associated with at least one of the entities for this branch.

[qcomlnxci]

Test jobs on c3e2277

• Job 141521 on lemans-evk
• Job 141516 on monaco-evk
• Job 141522 on qcs615-ride
• Job 141519 on qcs6490-rb3gen2
• Job 141517 on qcs8300-ride
• Job 141520 on qcs9100-ride-r3
• Job 141518 on x1e80100-crd

[qcomlnxci]

Test Matrix

Test Case	lemans-evk	monaco-evk	qcs615-ride	qcs6490-rb3gen2	qcs8300-ride	qcs9100-ride-r3	x1e80100-crd
BT_FW_KMD_Service	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
BT_ON_OFF	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
BT_SCAN	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
CPUFreq_Validation	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
CPU_affinity	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
DSP_AudioPD	✅ Pass	✅ Pass	⚠️ skip	✅ Pass	✅ Pass	⚠️ skip	◻️
Ethernet	⚠️ skip	✅ Pass	⚠️ skip	⚠️ skip	⚠️ skip	⚠️ skip	◻️
Freq_Scaling	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
GIC	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
IPA	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
Interrupts	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
OpenCV	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
PCIe	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
Probe_Failure_Check	❌ Fail	❌ Fail	✅ Pass	❌ Fail	❌ Fail	❌ Fail	◻️
RMNET	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
UFS_Validation	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
USBHost	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail	◻️
WiFi_Firmware_Driver	❌ Fail	❌ Fail	❌ Fail	✅ Pass	✅ Pass	✅ Pass	◻️
WiFi_OnOff	✅ Pass	❌ Fail	⚠️ skip	✅ Pass	✅ Pass	✅ Pass	◻️
adsp_remoteproc	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	❌ Fail	◻️
cdsp_remoteproc	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	❌ Fail	◻️
gpdsp_remoteproc	✅ Pass	✅ Pass	⚠️ skip	⚠️ skip	✅ Pass	❌ Fail	◻️
hotplug	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
irq	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
kaslr	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
pinctrl	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
qcom_hwrng	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
remoteproc	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	❌ Fail	◻️
rngtest	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
shmbridge	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
smmu	❌ Fail	✅ Pass	❌ Fail	✅ Pass	✅ Pass	❌ Fail	◻️
watchdog	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
wpss_remoteproc	✅ Pass	✅ Pass	⚠️ skip	✅ Pass	✅ Pass	✅ Pass	◻️