fix: repair cross-package bugs so all tests and tsc pass - #134
Open
stooit wants to merge 1 commit into
Open
Conversation
- utils: rename hook to useSearchDebounce and update barrel + apps/web consumer (was importing non-existent useThrottle) - ui: forward aria-label on Button with fallback for icon-only buttons (WCAG 2.2 SC 4.1.2) - ui: use functional updater form for DataTable sort toggle - utils: fix formatDate to day-first, no leading-zero day (en-GB numeric day / 2-digit month) - test env: wire root bunfig.toml preload to register happy-dom global DOM - tsconfig: add bun-types so tsc resolves bun:test No test files or dependencies changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests and type errors across the monorepo.
bun testnow reports 13 pass / 0 fail andnpx tsc --noEmitreports 0 errors. No test files were modified and no dependencies were added.Fixes (8 files, +42/-45)
useSearchDebounce(viagit mv), updated the@e2e/utilsbarrel export, and fixedapps/web/src/lib/api.tswhich was importing the non-existentuseThrottle.bunfig.tomlused an invalidenvironment = "happy-dom"key (silently ignored), so@testing-library/reacthad nodocument. Wiredpreloadto the existing happy-domGlobalRegistratorsetup so UI tests run from repo root. This alone fixed 9 of the failures.aria-labelonto the underlying<button>, with a fallback + dev warning for icon-only buttons (WCAG 2.2 SC 4.1.2).1/03/2024), usingen-GBnumeric-day / 2-digit-month options.bun-typesso tsc resolvesbun:test.Verification
Assumptions / reviewer notes (advisory, non-blocking)
A review pass confirmed no blockers and no suppressions (@ts-ignore, any, skipped tests). Follow-ups worth considering, none required by the tests: