fix: resolve 16 failing tests across utility modules - #304
Open
stooit wants to merge 1 commit into
Open
Conversation
… edge cases Implements TaskManager remove/update/sortBy and string truncate; corrects day rounding in formatRelative and relaxes email TLD / URL port validation. Fixes 16 failing tests (60/60 now pass).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 failing tests in the utility library. Test suite now passes 60/60 (was 44 pass / 16 fail). Only source files were changed — no test files modified, no dependencies added.
Changes by file
src/calculator.ts—dividenow throwsRangeErroron division by zero instead of returningInfinity(fail-fast on invalid input).src/string-utils.ts— implementedtruncate(reserves 3 chars for"...", cuts to word boundary); fixedwordCountto split on/\s+/so consecutive/other whitespace no longer inflates counts.src/task-manager.ts— implementedremove(Map.delete),update(partial update guarded by explicit key presence, returnsfalsefor unknown id), andsortBy(sorts a copy; data-driven priority/status rank maps;createdAtoldest-first).src/date-utils.ts—diffDaysusesMath.round(Math.abs(diffHours) / 24)instead ofMath.floor, fixing the off-by-one (36h → "2 days ago") symmetrically for past and future dates.src/validator.ts—isEmailTLD quantifier{2,4}→{2,}(accepts.museumetc.);isUrldrops the spurious empty-port check sohttp://localhost:3000validates, while retaining the http/https allow-list.Verification
bun test→ 60 pass / 0 failtsc --noEmitclean (strict mode)Assumptions & notes
truncate— left unchanged as no test requires it.dividethrowing is a behavioural change for any caller relying on nativeInfinitysemantics; the test and the original// BUG:comment both require the throw.isEmail/isUrlremain format-shape checks, not RFC-grade or SSRF-safe validation — appropriate for their current use.