fix: implement missing utilities and fix edge-case bugs - #306
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: divide now throws on division by zero instead of returning Infinity - string-utils: fix wordCount to collapse consecutive whitespace; implement truncate at word boundary with ellipsis counting toward maxLength - task-manager: implement remove, update, and sortBy methods - date-utils: fix off-by-one in formatRelative (Math.round instead of Math.floor) - validator: allow long TLDs in isEmail; accept URLs with ports in isUrl All 60 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 previously failing tests across the utility library (now 60 pass / 0 fail). Only source files were modified — no test files touched, no dependencies added.
Changes
dividenow throws on division by zero instead of silently returningInfinity.wordCountcollapses consecutive whitespace (splits on/\s+/); implementedtruncateto cut at a word boundary with"..."counting towardmaxLength, returning the string unchanged when within limit.remove,update, andsortBymethods (priority: high > medium > low; createdAt: oldest first; status ordering).formatRelative(Math.roundinstead ofMath.floor); 36 hours ago now reads "2 days ago".isEmailaccepts long alphabetic TLDs (e.g..museum);isUrlaccepts URLs with an explicit port (e.g.http://localhost:3000).Testing
bun test→ 60 pass, 0 fail.tsc --noEmitclean.Assumptions
truncatehard-slices whenmaxLength <= 3(no room for content + ellipsis), and only walks back to a word boundary when the cut lands mid-word.updateguards each field againstundefinedso a partial change object cannot blank out existing values.sortByrelies onArray.prototype.sortstability to preserve insertion order for equal keys.Note (out of test scope, not changed)
isEmailis a syntactic check only — it does not prove deliverability or ownership. If any caller gates account creation on it, that should be backed by a confirmation-link flow.