fix: repair failing tests across utility library - #307
Open
stooit wants to merge 1 commit into
Open
Conversation
Implement truncate/remove/update/sortBy, fix wordCount whitespace splitting, formatRelative day rounding, and email TLD/URL port validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 previously-failing tests across 5 source files. All 60 tests now pass;
tsc --noEmitis clean. Only source files were modified — no test files changed, no dependencies added.Changes
src/calculator.ts—dividenow throws on division by zero instead of returningInfinity(also catches-0).src/string-utils.ts—wordCountsplits on/\s+/(collapses consecutive whitespace); implementedtruncateto cut at a word boundary with"..."counting towardmaxLength, guarding themaxLength <= 3degenerate case.src/task-manager.ts— implementedremove,update(per-field, avoids clobbering withundefined), andsortBy(priority high>medium>low,createdAtoldest-first; sorts a copy so the internal Map isn't mutated on read).src/date-utils.ts—formatRelativeday calc usesMath.round(abs(hours)/24)instead ofMath.floor, fixing the 36h→"2 days ago" off-by-one and the future-date branch.src/validator.ts—isEmailaccepts long TLDs ({2,});isUrlaccepts explicit ports (dropped the erroneousport === ""check) while keeping the http/https allowlist.Assumptions & notes
isEmailremains a permissive format check (not full validation) andisUrlaccepts any host including internal ones (localhost, link-local). Both match the tests but are not security controls — if either gates a server-side fetch or ingress path, add SSRF/host-allowlist defences and confirmation-link email verification at the call site.Testing
bun test→ 60 pass / 0 fail.