Conversation
mfencik
force-pushed
the
kea
branch
3 times, most recently
from
5409658 to
6b4028c
Compare
Wraps the kea-dhcp chart (github.com/mglants/charts) as an ArgoCD Application, following the karma/dex external-chart pattern with chrony-style site-only scoping. Starts with upstream chart defaults.
The kea namespace can't be deployed to right now, so route the kea Application there as a stopgap. Revert this once kea namespace works.
DHCP needs to be reachable from the physical network, not just in-cluster, so default the kea-dhcp service to LoadBalancer for all sites.
The kea-dhcp chart (v0.7.1, and current main) renders invalid YAML when service.dhcp.annotations is non-empty. Sites needing an annotated LoadBalancer endpoint should add their own standalone Service in their deploy-repo overlay instead, so leave the chart's own Service at defaults (ClusterIP).
This reverts commit 1310e62. We cannot use option 234, because the flex_option expression only has access to the DHCPDISCOVER, not reservations.
Instead of sending a request to a traditional kubernetes Service, we must send the request to all of the pods. In order to do that, we make a DNS lookup on the headless service and send the request to all of the pods using the service's port.
The success return was outside the try/except but inside the attempt loop, so it always returned (or raised IndexError) after the first attempt regardless of success. Retries never actually ran, silently dropping reservations for ports that hit a transient request failure.
…move list.pop() expects an index, not a value; passing the reservation dict raised TypeError, silently swallowed by the broad except clause, so clean_dhcp_opts never actually removed reservations.
These prints were left over from troubleshooting the Kea cleaning path and would spam stdout in production; route them through the standard oslo logger instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.