Harden LDAP authentication against empty credentials - #102
Open
AugustoMagalhaes wants to merge 2 commits into
Open
AugustoMagalhaes wants to merge 2 commits into
AugustoMagalhaes wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LDAPAuthentifier.login()only rejectedNonecredentials and forwarded empty strings tosimple_bind_s(). An empty password results in an LDAP unauthenticated bind (RFC 4513 §5.1.2), which some directory servers accept as a successful bind without verifying credentials.This change validates credentials before any LDAP operation:
Tests
Added regression tests ensuring an empty password never reaches
simple_bind_s(), and that blank usernames and non-string credentials are rejected before any LDAP operation. Also verified passwords containing spaces are still accepted.Notes
Reported privately to the maintainer beforehand; opening the PR as requested.