Skip to content

Fix nav bar overlapping the top of rendered notebook pages - #56

Merged
e-koch merged 1 commit into
radio-astro-tools:masterfrom
e-koch:fix-nav-header-overlap
Sep 10, 2026
Merged

e-koch merged 1 commit into
radio-astro-tools:masterfrom
e-koch:fix-nav-header-overlap

Conversation

@e-koch

@e-koch e-koch commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

Test plan

  • Rendered fitting_with_spectralcube.ipynb locally (nbconvert 7.16.4, not executed), ran insert_header.inject() on it, and measured the layout in headless Chromium (Brave) at 1400px and 600px widths:

    computed body padding-top nav bottom first blockquote top
    before 10px 42px 29px (13px under the nav)
    after 60px 42px 79px (37px clear)
  • After merge, confirm on the live site that the "Questions or issues?" note is fully visible below the nav.

Note: CI's nbconvert version isn't pinned (it comes in via notebook), so a future template that renames the <body> class could bring this back.

🤖 Generated with Claude Code

The padding added in radio-astro-tools#51/radio-astro-tools#53 never took effect. nbconvert's lab template
renders <body class="jp-Notebook">, and its `.jp-Notebook { padding:
var(--jp-notebook-padding); }` rule (10px) outranks a bare `body`
selector regardless of source order, so the computed padding-top stayed
at 10px and the 42px nav bar covered the first notebook cell (the
"Questions or issues?" note).

Match `body.jp-Notebook` as well so the 60px padding wins.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@e-koch
e-koch merged commit 6299c14 into radio-astro-tools:master Sep 10, 2026
2 checks passed
@e-koch
e-koch deleted the fix-nav-header-overlap branch September 10, 2026 21:14
e-koch added a commit that referenced this pull request Sep 10, 2026
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant