fix: disable hidden balance queries - #2696
ayaanoncrypto wants to merge 2 commits into
Conversation
|
Someone is attempting to deploy a commit to the rainbowdotme Team on Vercel. A member of the Team first needs to authorize it. |
馃 Changeset detectedLatest commit: fa0a06f The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e3e0e0a631
鈩癸笍 About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| address: includeBalance ? address : undefined, | ||
| address, | ||
| query: { | ||
| enabled: includeBalance !== false, |
There was a problem hiding this comment.
Add a changeset for the balance-query fix
When the next release is generated, this user-facing change has no .changeset entry to schedule a patch bump and document the fix, so @rainbow-me/rainbowkit may not be released for this commit. Add a patch changeset for the core package as required by the repository release workflow.
AGENTS.md reference: AGENTS.md:L99-L104
Useful? React with 馃憤聽/ 馃憥.
Summary
Fix hidden balance fetching when
showBalanceis false.useProfilenow passes an explicitquery.enabledflag to wagmi. RainbowKit keeps the wallet address available for profile data, while disabling the balance query when the UI does not display a balance.Tests
Added
useProfile.test.tswith coverage for enabled and disabled balance queries.git diff --checkpasses.The local dependency installation hit filesystem inode exhaustion before Vitest could run.