Conversation
🦋 Changeset detectedLatest commit: 5f3eaf6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@jackkru69 is attempting to deploy a commit to the rainbowdotme Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 05fd323d1d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
9b43a68 to
b173172
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b173172e4c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
b173172 to
5f3eaf6
Compare
Summary
Fixes Brave Wallet connections on mobile browsers requiring a second tap in RainbowKit’s connect modal.
Problem
Wagmi’s injected connector uses
wallet_requestPermissionswhenshimDisconnectis enabled. On Brave mobile, the permission response may not include account addresses incaveats, causing Wagmi to fall back toeth_requestAccounts.While the native permissions dialog is still closing, that second request can fail with
-32002(“Already processing request”), leaving the modal open until the user taps the connector again.Solution
shimDisconnectbehavior, so an explicit disconnect remains persisted across reloads.wallet_requestPermissionsis fulfilled through one directeth_requestAccountsrequest and returns a Wagmi-compatible permission response.connector.connect(). After connecting,connector.getProvider()resolves to the original Brave provider, so application-initiatedwallet_requestPermissionscalls and their caveats are forwarded unchanged.Testing
pnpm testpnpm --filter @rainbow-me/rainbowkit typecheck