fix: give account modal an accessible name - #2701
Closed
devtechedge wants to merge 1 commit into
Closed
devtechedge wants to merge 1 commit into
devtechedge wants to merge 1 commit into
Conversation
|
@devtechedge is attempting to deploy a commit to the rainbowdotme Team on Vercel. A member of the Team first needs to authorize it. |
馃 Changeset detectedLatest commit: 4530481 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Author
|
Hi, just checking in on this one. It gives the account modal an accessible name for assistive tech. Open since 3 September with green checks and no conflicts. Happy to adjust anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2700.
The account modal dialog sets
aria-labelledby="rk_account_modal_title", butProfileDetailshardcodedid="rk_profile_title"on its headings. The labelled-by id never resolved, so the dialog had no accessible name.Changes
titleIdfromAccountModalintoProfileDetailsso the heading id matches the dialog, same pattern asChainModal/ the connect modal.aria-labelledbywhen a balance is shown.Test plan
document.getElementById('rk_account_modal_title')returns the account-name heading while the modal is open.