Conversation
AccountModal set aria-labelledby="rk_account_modal_title" on its dialog, but ProfileDetails rendered its heading with its own hardcoded id, rk_profile_title, and put that same id on the balance heading as well. The reference never resolved, so the modal was announced as an unnamed dialog, and the duplicated id was invalid on its own. ProfileDetails now takes the titleId from AccountModal and renders it on the account name only, the way ChainModal and the connect flow already pair a dialog with its heading. Fixes rainbow-me#2700
|
@owenpkent is attempting to deploy a commit to the rainbowdotme Team on Vercel. A member of the Team first needs to authorize it. |
馃 Changeset detectedLatest commit: 03de295 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2700.
What
AccountModalsetsaria-labelledby="rk_account_modal_title"on its dialog, but the body it renders,ProfileDetails, hardcoded its own heading id,rk_profile_title, and put that same id on the balance heading as well. The reference never resolved, so the account modal was announced as an unnamed dialog, and the duplicated id was invalid on its own.ProfileDetailsnow takes thetitleIdfromAccountModaland renders it on the account name only. The dialog is therefore announced by the connected address or ENS name, the wayChainModaland the connect flow already pair a dialog with its heading. No user-facing strings change, so no locale files are touched.Testing
AccountModal.test.tsx, in the style ofChainModal.test.tsx: connects the mock wallet, then asserts the dialog'saria-labelledbyresolves to exactly one element, that the element holds the formatted address, and that the dialog's accessible name is that address.pnpm test(full suite),biome lint,biome checkand the package typecheck all pass locally.aria-dialog-nameandaria-valid-attr-valueon the account modal went from 6 occurrences (the modal opened from idle, pending and confirmed states) to 0, and Equal Accessaria_id_uniquefrom 3 to 0, with no other finding changed.Changeset included (patch).