fix: show mobile download link when wallet app may be missing - #2703
devtechedge wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 3bbb259 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@devtechedge is attempting to deploy a commit to the rainbowdotme Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 064e0786e8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| </Text> | ||
| </Box> | ||
|
|
||
| {mobileDownloadUrl ? ( |
There was a problem hiding this comment.
Add a changeset for this user-facing fix
This commit changes the mobile connection UI but adds no .changeset entry (the directory has only its README). Without a package version bump, this fix cannot be published in the next release; add a patch changeset for @rainbow-me/rainbowkit.
AGENTS.md reference: AGENTS.md:L99-L104
Useful? React with 👍 / 👎.
|
Circling back on this fix. It shows a mobile download link when the wallet app may be missing, instead of a dead end. Open since 6 September with green checks and no conflicts. Let me know if you would like anything changed. |
Summary
On mobile, picking a wallet deep-links into the app (
rainbow://..., etc.). If the app is not installed, the browser blocks or no-ops the custom scheme and the connecting screen only said "Continue in {wallet}" / "Accept connection request", with no install path. That is #2574.Desktop already has install / GET secondary actions. This mirrors that on the mobile connecting status screen.
Changes
MobileStatus, when the selected wallet has a mobile download URL, show the existing "Don't have {wallet}?" copy plus a GET button that opens the App Store / Play Store / mobile download link viagetMobileDownloadUrl.Test plan
downloadUrlsstill shows the previous connecting UI onlyFixes #2574