Repository navigation
Record the Mermaid render result when the console isolation test fails - #546
Draft
raiseCatError wants to merge 1 commit into
Draft
raiseCatError wants to merge 1 commit into
raiseCatError wants to merge 1 commit into
Conversation
Hosted macOS CI has failed this assertion twice (runs 40630147755 and 43064876487) without saying which code the renderer returned. The assertion is unchanged; on failure it now prints the result's code and reason. A successful result carries the drawn picture, so the message is only built when the render failed.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
tests/browserConsoleChrome.test.ts(test "a reload starts a new document; NMSh's find world, web pages and the Mermaid renderer never report"): when the assertion fails, it now prints the renderer's result. The assertion itself is unchanged:On success the result carries the drawn PNG, so the message is only built when the render failed. The timeout (10 s) and the rest of the test are unchanged.
Why
This assertion fails intermittently on hosted macOS CI, and the failure output never shows which code the renderer returned (
timeout,crashedorfailed, fromsrc/browser/engine/diagram.ts):cece7ed9), macOS 1/3: failed at line 106 after 17.3 sNeither PR touches browser or diagram code. Both durations are consistent with the 10 s render
timeout, but the logs don't prove it. With this change, the next failure records the code and reason.Verification
tsc --noEmitandgit diff --checkare clean.NMSH_TEST_MERMAIDwas unset, solocateMermaidreturned not-ok and the test silently skipped the render step. CI installs Mermaid 12.2.0 for this test, so this PR's macOS CI shards are the run that matters.No human terminal testing is needed; this changes test output only.