Repository navigation
docs: extract agent-neutral install requirements from the Bob doc - #492
Merged
Merged
Conversation
Move the minimum file tree, <plugin root> resolution, and the adept-side half of the Claude Code/Codex-only feature table into docs/agent-install-requirements.md, written against <install root>. The Bob doc keeps its install root, sections 3-5 and 7, and the Bob column of section 6, and links the core for the rest. Refs #483
Owner
Author
|
verdict: approve Forge whole-branch reviewReview exit payloadsEscalation: the single-pass Deferrals: none. Follow-up candidates:
Rejected with evidence:
Outstanding notes: none. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Splits
docs/bob-install-requirements.mdinto an agent-neutral core and the Bob-specific remainder, so the per-agent docs planned under #482 (#484–#487) can link one copy of the shared facts.docs/agent-install-requirements.mdholds what was Bob doc §1 (minimum file tree), §2 (<plugin root>resolution under copy vs symlink installs), and the adept-side half of §6 (the Claude Code/Codex-only feature table with itsadept locationcolumn and theagents/openai.yamldescription).~/.bob/is replaced by<install root>/~/.<agent>/placeholders, and the verification-marker legend now lives here with its environment line unchanged.docs/bob-install-requirements.mdkeeps §3, §4, §5, §7 and the Bob column of §6. A short "1–2. Install root" section states Bob's install roots (~/.bob/,<project>/.bob/), keeps the Bob-specific project-precedence sentence, and links the core. Section numbers 3–7 are unchanged; §4's reference to §2 now links the core. §7 is byte-identical..claude-plugin/plugin.json7.12.4 → 7.12.5 (PATCH, ADR 0022).Claims are moved, not rewritten. The only wording changes are placeholder substitutions, "Bob install" → "install" in moved sentences, "the issue body" → "Issue #478's body" (it no longer sits beside the Bob doc's #478 reference), and the marker legend's "Bob's published documentation"/"IBM" → "the agent's"/"the agent's vendor". The Bob §6
agents/openai.yamlcell drops "these files are Codex CLI-specific", which the core now states.Verification
BASE_SHA=<base> ./scripts/check-plugin-version.sh: exit 1 before the bump, exit 0 after.just commit-check,just shape-check,just plugin-check: exit 0.just ci) on the pushed head: exit 0.$trial-loop, which fixed the finding in 24cb65c and approved on its confirming pass.Closes #483
Review exit payloads
Escalation: the single-pass
gauntletreview (lensconsumer-installation) returned one high finding, which escalated the review to$trial-loop(lenspublic-safety, budget 2). Pass 1 raised the same finding: leftover pre-change §6 table rows and detail paragraph indocs/bob-install-requirements.md. It was accepted and fixed in 24cb65c. Pass 2 approved. Review rounds: 2 this run, 3/1 cumulative.Deferrals: none.
Follow-up candidates:
check-public-safety.sh:4,11points past theexeclinedocs/agent-install-requirements.md§1 note citesscripts/check-public-safety.sh:4,11; the script is 9 lines withexecat line 9 (pre-existing in the Bob doc):4,9in a follow-up; this PR moves claims without rewriting themRejected with evidence:
Outstanding notes: none.