Skip to content

fix: classify report configuration overrides - #1939

Merged
randomparity merged 5 commits into
mainfrom
feat/report-config-classification-1891
Nov 5, 2026
Merged

randomparity merged 5 commits into
mainfrom
feat/report-config-classification-1891

Conversation

@randomparity

@randomparity randomparity commented Nov 5, 2026 •

Copy link
Copy Markdown
Owner

Report utilization now classifies every HMCConfig field explicitly. It refuses environment exports for all 19 per-profile fields, including SSH credentials, host-key verification, security controls and survey limits. Only timeout and schema_version remain global overrides. Refusal remains case-insensitive and includes empty exports, before profile loading or survey work.

Tests cover the complete field partition, schema drift, direct report admission, representative valid and empty exports through the public CLI, and both global overrides through the real profile loader. The CLI documentation and ADR 0338 record the approved partition. Global-option diagnostics remain separate work in #1892.

Validation: 120 focused report tests and 403 assembled report/config/survey tests passed. Controlled faults confirmed the new-field drift check, SSH-key refusal and global timeout allowance detect regressions. Final just verify passed in 1232.120 seconds (one full candidate run, including the configured coverage gate, smoke, build and artifact checks); uv run --no-sync prek run --all-files passed in 121.188 seconds. No live HMC was used.

Requested by #1891 under the authorized campaign. The operator approved the exact 19 refused / 2 global classification. Scope remains report utilization only.

Closes #1891

Review exit payloads

  • Design pass 1 (2d242d41-42c9-41e1-ba57-09f6f20318f9): the nonblocking proportionality note was addressed by cutting duplicated narrative once. The measured design is 214/100 = 2.14x; the remaining note is accepted because the approved field partition, failure model and verification obligations remain necessary. The original denominator is unchanged.
  • Two design suppressions remain accepted under the trusted local CLI model: concurrent mutation of the process environment, and untested downstream source edits. Maintained releases still enforce the new-field drift test. Neither creates new debt.
  • Scope audit approved the unchanged 19 refused / 2 global policy. Concerns about unused fields were rejected because the operator approved classification of every field; option-diagnostic work remains outside this issue under Name every refused global option in report utilization's error and guide #1892.
  • Final branch pass (bd320d58-aff4-43c7-9349-6ec783113257): approve, zero findings or suppressions, one valid pass of a two-pass budget. Cumulative design and branch review rounds: 2 across 1 scope charter. No malformed retries or replacement reviewers. One separate scope audit and one security pass (7333b551-ae4d-47f4-8f68-bdae2f8ec722) approved; security found no findings or suppressions.
  • Deferrals, new follow-up candidates, outstanding correctness findings and bounty occurrences: none. No live HMC verification was requested or performed.

@randomparity

Copy link
Copy Markdown
Owner Author

verdict: approve
exit: none
findings: 0
iterations: 1
security: approve
delivered-head-sha: 83b080c

Forge whole-branch review

forge review: not required (Cast direct execution of coupled report classification and documentation tasks)

Review exit payloads

  • Design pass 1 (2d242d41-42c9-41e1-ba57-09f6f20318f9): the nonblocking proportionality note was addressed by cutting duplicated narrative once. The measured design is 214/100 = 2.14x; the remaining note is accepted because the approved field partition, failure model and verification obligations remain necessary. The original denominator is unchanged.
  • Two design suppressions remain accepted under the trusted local CLI model: concurrent mutation of the process environment, and untested downstream source edits. Maintained releases still enforce the new-field drift test. Neither creates new debt.
  • Scope audit approved the unchanged 19 refused / 2 global policy. Concerns about unused fields were rejected because the operator approved classification of every field; option-diagnostic work remains outside this issue under Name every refused global option in report utilization's error and guide #1892.
  • Final branch pass (bd320d58-aff4-43c7-9349-6ec783113257): approve, zero findings or suppressions, one valid pass of a two-pass budget. Cumulative design and branch review rounds: 2 across 1 scope charter. No malformed retries or replacement reviewers. One separate scope audit and one security pass (7333b551-ae4d-47f4-8f68-bdae2f8ec722) approved; security found no findings or suppressions.
  • Deferrals, new follow-up candidates, outstanding correctness findings and bounty occurrences: none. No live HMC verification was requested or performed.

@randomparity
randomparity merged commit 71b8a49 into main Nov 5, 2026
31 checks passed
@randomparity
randomparity deleted the feat/report-config-classification-1891 branch November 5, 2026 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Derive report utilization's per-profile override refusal from HMCConfig fields

1 participant