Repository navigation
fix: classify report configuration overrides - #1939
Merged
Merged
Conversation
Owner
Author
|
verdict: approve Forge whole-branch reviewReview exit payloads
|
…ort-config-classification-1891
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report utilization now classifies every HMCConfig field explicitly. It refuses environment exports for all 19 per-profile fields, including SSH credentials, host-key verification, security controls and survey limits. Only timeout and schema_version remain global overrides. Refusal remains case-insensitive and includes empty exports, before profile loading or survey work.
Tests cover the complete field partition, schema drift, direct report admission, representative valid and empty exports through the public CLI, and both global overrides through the real profile loader. The CLI documentation and ADR 0338 record the approved partition. Global-option diagnostics remain separate work in #1892.
Validation: 120 focused report tests and 403 assembled report/config/survey tests passed. Controlled faults confirmed the new-field drift check, SSH-key refusal and global timeout allowance detect regressions. Final
just verifypassed in 1232.120 seconds (one full candidate run, including the configured coverage gate, smoke, build and artifact checks);uv run --no-sync prek run --all-filespassed in 121.188 seconds. No live HMC was used.Requested by #1891 under the authorized campaign. The operator approved the exact 19 refused / 2 global classification. Scope remains report utilization only.
Closes #1891
Review exit payloads