Repository navigation
fix: name supplied global options in utilization refusal - #1942
Merged
Merged
Conversation
Owner
Author
|
verdict: approve Forge whole-branch reviewReview exit payloads
|
…ort-option-diagnostics-1892
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
report utilizationnow names only the supplied global connection options in its refusal, using the existing canonical option identities. The CLI guide lists the complete refused set, aliases and boolean polarities, and distinguishes the report-local profile selector.Public CLI regression tests cover the eight identities, short aliases, negative switches, repeated flags and mixed options. They assert exact names without argument values, exit 2, and no profile inventory, loading, survey or report file. Restoring the old fixed list causes all 14 cases to fail. The report, HTML and CLI help checks passed 194 tests.
The diagnostic retains canonical positive long names rather than original alias spelling, and earlier validation errors still take precedence. Configuration and acceptance behavior are unchanged.
Validation:
just verifypassed once (1150.418 seconds, including the configured coverage gate, MCP smoke and artifact verification); pinneduv run --no-sync prek run --all-filespassed (107.737 seconds).Requested by #1892 under campaign
152593d7a535-fdfc969e-824d-4d69-a9ae-3ce95496903a.Closes #1892
Review exit payloads